From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions Date: Mon, 16 Jun 2014 17:22:34 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402953803 24033 80.91.229.3 (16 Jun 2014 21:23:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2014 21:23:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Barzilay Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 16 23:23:17 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WweN3-0001W8-4J for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2014 23:23:17 +0200 Original-Received: from localhost ([::1]:46336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WweN2-00034j-K4 for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2014 17:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WweMt-00033b-DR for emacs-devel@gnu.org; Mon, 16 Jun 2014 17:23:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WweMk-0004yN-Jf for emacs-devel@gnu.org; Mon, 16 Jun 2014 17:23:07 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:44160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WweMk-0004yJ-FQ for emacs-devel@gnu.org; Mon, 16 Jun 2014 17:22:58 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id BDA2F24133; Mon, 16 Jun 2014 17:22:57 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A7C951E5B74; Mon, 16 Jun 2014 17:22:34 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 850EFB4167; Mon, 16 Jun 2014 17:22:34 -0400 (EDT) In-Reply-To: (Eli Barzilay's message of "Sun, 15 Jun 2014 04:52:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.6, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_MONNAIE 0.22, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172490 Archived-At: > * lisp/calculator.el: Lots of revisions > - Kill the calculator buffer after electric mode too. > - Make decimal mode have "," groups, so it's more fitting for use in > money calculations. > - Factorial works with non-integer inputs. > - Swallow less errors. > - Lots of other improvements, but no changes to custom variables, or > other user visible changes (except the above). The above description is the kind of thing that should go into etc/NEWS. But you forgot to include a ChangeLog entry for that commit. For the ChangeLog entry, you should instead include details about which parts of the code you changed (see https://www.gnu.org/prep/standards/html_node/Change-Logs.html). You can use "C-x 4 a" (both from the calculator.el and the *vc-diff* buffers) to help you write that. And the commit message should be a textual copy of the ChangeLog entry just with the leading TABs stripped (you can use C-c C-a from the *vc-log* buffer to let Emacs fetch that ChangeLog text for you). Stefan