From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: More metaproblem Date: Wed, 10 Dec 2014 15:28:01 -0500 Message-ID: References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <20141203192721.GE12748@thyrsus.com> <547F6774.50700@cs.ucla.edu> <838uio5vjw.fsf@gnu.org> <20141203211447.GB15111@thyrsus.com> <871toge5zw.fsf@floss.red-bean.com> <83388v6hsq.fsf@gnu.org> <87egsftgd5.fsf@ktab.red-bean.com> <83egsf3yci.fsf@gnu.org> <87iohq6nvn.fsf@ktab.red-bean.com> <85bnnhkuep.fsf@stephe-leake.org> <857fy4ipsd.fsf@stephe-leake.org> <85y4qjdsg0.fsf@stephe-leake.org> <548616BE.3050701@cumego.com> <5488A885.4000400@cumego.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418243400 1682 80.91.229.3 (10 Dec 2014 20:30:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 20:30:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?Przemys=C5=82aw?= Wojnowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 21:29:52 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XyntJ-0007lY-Ip for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2014 21:29:45 +0100 Original-Received: from localhost ([::1]:47815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyntJ-0007rS-1a for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2014 15:29:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xynsy-0007qD-42 for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:29:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xynso-0005Ed-OP for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:29:24 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:39225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xynso-0005ER-Ji for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:29:14 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sBAKS1mm011726; Wed, 10 Dec 2014 15:28:02 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7160A6610C; Wed, 10 Dec 2014 15:28:01 -0500 (EST) In-Reply-To: <5488A885.4000400@cumego.com> (=?utf-8?Q?=22Przemys=C5=82aw?= Wojnowski"'s message of "Wed, 10 Dec 2014 21:09:41 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5151=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5151> : inlines <1623> : streams <1354818> : uri <1838053> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179698 Archived-At: > What about this one? Is refactoring to small, cohesive functions > accepted? For example function abbrev--before-point from the first > elisp file abbrev.el is quite big and I can imagine it's hard to test > automatically. It could be split into couple smaller ones on single > level of abstraction. Such functions would be easier to test > and understand. Indeed, we have a good number of functions that are too large for good taste. I generally like breaking them up when I find a way to do it cleanly. Stefan