From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Getting rid of low-level assumptions in yasnippet Date: Fri, 20 Mar 2015 10:18:12 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426861123 32355 80.91.229.3 (20 Mar 2015 14:18:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 14:18:43 +0000 (UTC) Cc: Akira Kitada , Tassilo Horn , emacs-devel@gnu.org To: joaotavora@gmail.com (=?windows-1252?B?Sm/jbyBU4XZvcmE=?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 20 15:18:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYxkm-0000em-I3 for ged-emacs-devel@m.gmane.org; Fri, 20 Mar 2015 15:18:24 +0100 Original-Received: from localhost ([::1]:44058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYxkl-0001bl-T3 for ged-emacs-devel@m.gmane.org; Fri, 20 Mar 2015 10:18:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYxkj-0001bd-9E for emacs-devel@gnu.org; Fri, 20 Mar 2015 10:18:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYxki-00071T-7V for emacs-devel@gnu.org; Fri, 20 Mar 2015 10:18:21 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYxkc-0006yz-SJ; Fri, 20 Mar 2015 10:18:14 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2KEIDrj029644; Fri, 20 Mar 2015 10:18:13 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ECDCAF63; Fri, 20 Mar 2015 10:18:12 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1v?= =?windows-1252?Q?ora=22's?= message of "Fri, 20 Mar 2015 11:03:20 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5251=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5251> : inlines <2452> : streams <1408625> : uri <1885569> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184037 Archived-At: >> Could you double check the patch below, to make sure it does the right thing? >> The main thrust is to get rid of the use of the `cl-struct-slots' >> property which doesn't exist in Emacs-25 any more. > The patch look good. I've pushed it upstream and it passes all tests. Great, thanks. > One thing I don't know how to handle is the Git submodules which are > problematic for some (unofficial) uses of ELPA.git, such as > https://github.com/quelpa/quelpa (CCing akira) Indeed git submodules don't work in elpa.git. The cleanest way would be to divide yasnippet into separate (sub)packages. > So unless you disagree, I'll remove them completely in the subtree merge > result and (temporarily) replace yasnippet/snippets with a copy of the > old snippet collection. Sure, Stefan