From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: joaotavora@gmail.com (João Távora)
Cc: Akira Kitada <akitada@gmail.com>, Tassilo Horn <tsdh@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Getting rid of low-level assumptions in yasnippet
Date: Fri, 20 Mar 2015 10:18:12 -0400 [thread overview]
Message-ID: <jwva8z7zrfh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jjbzj78c4nb.fsf@gmail.com> ("João Távora"'s message of "Fri, 20 Mar 2015 11:03:20 +0000")
>> Could you double check the patch below, to make sure it does the right thing?
>> The main thrust is to get rid of the use of the `cl-struct-slots'
>> property which doesn't exist in Emacs-25 any more.
> The patch look good. I've pushed it upstream and it passes all tests.
Great, thanks.
> One thing I don't know how to handle is the Git submodules which are
> problematic for some (unofficial) uses of ELPA.git, such as
> https://github.com/quelpa/quelpa (CCing akira)
Indeed git submodules don't work in elpa.git. The cleanest way would be
to divide yasnippet into separate (sub)packages.
> So unless you disagree, I'll remove them completely in the subtree merge
> result and (temporarily) replace yasnippet/snippets with a copy of the
> old snippet collection.
Sure,
Stefan
next prev parent reply other threads:[~2015-03-20 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:49 Getting rid of low-level assumptions in yasnippet Stefan Monnier
2015-03-20 11:03 ` João Távora
2015-03-20 14:18 ` Stefan Monnier [this message]
2015-03-28 15:59 ` João Távora
2015-03-28 20:32 ` Stefan Monnier
2015-03-28 21:23 ` João Távora
2015-03-29 19:36 ` Matthew Fidler
2015-03-30 0:47 ` Stefan Monnier
2015-03-30 15:15 ` Matthew Fidler
2015-03-30 18:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva8z7zrfh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=akitada@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).