* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
[not found] ` <E1aXuK3-0005Mz-Ua@vcs.savannah.gnu.org>
@ 2016-02-22 18:50 ` Stefan Monnier
2016-02-22 19:30 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2016-02-22 18:50 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> +After a command is executed, if point moved into a region that has
> +special properties (e.g. composition, display), Emacs adjusts point to
> +the boundary of the region. But when a command binds this variable to
> +non-nil, this point adjustment is suppressed.
Why did you replace "sets" with "binds"?
AFAIK let-binding this variable has no effect because the variable is
consulted only after the command finishes, i.e. after the binding has
been undone.
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
2016-02-22 18:50 ` [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment' Stefan Monnier
@ 2016-02-22 19:30 ` Eli Zaretskii
2016-02-22 20:45 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-22 19:30 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 22 Feb 2016 13:50:37 -0500
>
> > +After a command is executed, if point moved into a region that has
> > +special properties (e.g. composition, display), Emacs adjusts point to
> > +the boundary of the region. But when a command binds this variable to
> > +non-nil, this point adjustment is suppressed.
>
> Why did you replace "sets" with "binds"?
> AFAIK let-binding this variable has no effect because the variable is
> consulted only after the command finishes, i.e. after the binding has
> been undone.
Who said anything about let-binding?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
2016-02-22 19:30 ` Eli Zaretskii
@ 2016-02-22 20:45 ` Stefan Monnier
2016-02-22 20:53 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2016-02-22 20:45 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> > +After a command is executed, if point moved into a region that has
>> > +special properties (e.g. composition, display), Emacs adjusts point to
>> > +the boundary of the region. But when a command binds this variable to
>> > +non-nil, this point adjustment is suppressed.
>>
>> Why did you replace "sets" with "binds"?
>> AFAIK let-binding this variable has no effect because the variable is
>> consulted only after the command finishes, i.e. after the binding has
>> been undone.
> Who said anything about let-binding?
To me the difference between "sets" and "binds" is that the former
clearly means "setq" while the other can either mean "change it from
unbound to bound" or "let-binds".
So, I find "binds" to be less precise than "sets", hence my question:
Why did you replace "sets" with "binds"?
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
2016-02-22 20:45 ` Stefan Monnier
@ 2016-02-22 20:53 ` Eli Zaretskii
2016-02-22 21:13 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-22 20:53 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: emacs-devel@gnu.org
> Date: Mon, 22 Feb 2016 15:45:35 -0500
>
> To me the difference between "sets" and "binds" is that the former
> clearly means "setq" while the other can either mean "change it from
> unbound to bound" or "let-binds".
>
> So, I find "binds" to be less precise than "sets", hence my question:
> Why did you replace "sets" with "binds"?
Because that's how I tend to think about the act of giving a value to
a variable in Emacs Lisp.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
2016-02-22 20:53 ` Eli Zaretskii
@ 2016-02-22 21:13 ` Stefan Monnier
2016-02-23 3:27 ` Eli Zaretskii
[not found] ` <<83fuwkjecd.fsf@gnu.org>
0 siblings, 2 replies; 10+ messages in thread
From: Stefan Monnier @ 2016-02-22 21:13 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> To me the difference between "sets" and "binds" is that the former
>> clearly means "setq" while the other can either mean "change it from
>> unbound to bound" or "let-binds".
>> So, I find "binds" to be less precise than "sets", hence my question:
>> Why did you replace "sets" with "binds"?
> Because that's how I tend to think about the act of giving a value to
> a variable in Emacs Lisp.
OK. To me, the fact that disable-point-adjustment needs to be setq'd by
the command rather than let-bound is an important point (I'd expect this
to surprise many coders since the usual way for a command to affect the
behavior of Emacs "for this command only" is to let-bind a variable), so
I find the new wording to encourage confusion rather than trying to
avoid it.
But clearly you have a different opinion, and I honestly can't claim to
know better, especially when it comes to writing docs, so I'll shut up
now,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
2016-02-22 21:13 ` Stefan Monnier
@ 2016-02-23 3:27 ` Eli Zaretskii
2016-02-23 3:40 ` Lars Ingebrigtsen
[not found] ` <<83fuwkjecd.fsf@gnu.org>
1 sibling, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-02-23 3:27 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: emacs-devel@gnu.org
> Date: Mon, 22 Feb 2016 16:13:36 -0500
>
> >> Why did you replace "sets" with "binds"?
> > Because that's how I tend to think about the act of giving a value to
> > a variable in Emacs Lisp.
>
> OK. To me, the fact that disable-point-adjustment needs to be setq'd by
> the command rather than let-bound is an important point (I'd expect this
> to surprise many coders since the usual way for a command to affect the
> behavior of Emacs "for this command only" is to let-bind a variable), so
> I find the new wording to encourage confusion rather than trying to
> avoid it.
If this is confusing, I will changing it back. What do others think?
^ permalink raw reply [flat|nested] 10+ messages in thread[parent not found: <<83fuwkjecd.fsf@gnu.org>]
* RE: [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment'
[not found] ` <<83fuwkjecd.fsf@gnu.org>
@ 2016-02-23 7:10 ` Drew Adams
2016-02-23 17:37 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Drew Adams @ 2016-02-23 7:10 UTC (permalink / raw)
To: Eli Zaretskii, Stefan Monnier; +Cc: emacs-devel
> > >> Why did you replace "sets" with "binds"?
> > > Because that's how I tend to think about the act of giving a value to
> > > a variable in Emacs Lisp.
> >
> > OK. To me, the fact that disable-point-adjustment needs to be setq'd by
> > the command rather than let-bound is an important point (I'd expect this
> > to surprise many coders since the usual way for a command to affect the
> > behavior of Emacs "for this command only" is to let-bind a variable), so
> > I find the new wording to encourage confusion rather than trying to
> > avoid it.
>
> If this is confusing, I will changing it back. What do others think?
I agree with Stefan here. Generally use "set" for assignment
(regardless of whether the symbol has already been bound in any
way). Use "bind" for a `let' binding.
It's true that we also speak of a symbol being unbound or bound
depending on whether its value cell is void. But most of the
uses of "bound" and "bind" for symbols in Emacs have to do with
`let' bindings.
However, if it is important in this particular context to make
clear that "disable-point-adjustment needs to be setq'd by the
command rather than let-bound" then I'd say that, to remove any
ambiguity.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-02-23 17:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160222173059.20603.67344@vcs.savannah.gnu.org>
[not found] ` <E1aXuK3-0005Mz-Ua@vcs.savannah.gnu.org>
2016-02-22 18:50 ` [Emacs-diffs] emacs-25 6bd9d69: Fix documentation of 'global-disable-point-adjustment' Stefan Monnier
2016-02-22 19:30 ` Eli Zaretskii
2016-02-22 20:45 ` Stefan Monnier
2016-02-22 20:53 ` Eli Zaretskii
2016-02-22 21:13 ` Stefan Monnier
2016-02-23 3:27 ` Eli Zaretskii
2016-02-23 3:40 ` Lars Ingebrigtsen
2016-02-23 4:16 ` Kaushal Modi
[not found] ` <<83fuwkjecd.fsf@gnu.org>
2016-02-23 7:10 ` Drew Adams
2016-02-23 17:37 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).