unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn
       [not found] ` <20170815220621.13CA220C81@vcs0.savannah.gnu.org>
@ 2017-08-15 22:23   ` Stefan Monnier
  2017-08-15 22:29     ` Eric Abrahamsen
  0 siblings, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2017-08-15 22:23 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eric Abrahamsen

>     Fix up headers for ebdb-i18n-chn
    
>     * packages/ebdb-i18n-chn/ebdb-i18n-chn.el: There was no Maintainer
>       header -- was that why it didn't deploy?

No: "Author" is used when there's no "maintainer" (actually: "was
used", since currently that part of the infrastructure is not working).

The problem was in the "Package-Requires" line.  I just fixed it.


        Stefan



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn
  2017-08-15 22:23   ` [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn Stefan Monnier
@ 2017-08-15 22:29     ` Eric Abrahamsen
  2017-08-21 18:04       ` João Távora
  2017-09-05  9:11       ` Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn) Michael Heerdegen
  0 siblings, 2 replies; 14+ messages in thread
From: Eric Abrahamsen @ 2017-08-15 22:29 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>     Fix up headers for ebdb-i18n-chn
>     
>>     * packages/ebdb-i18n-chn/ebdb-i18n-chn.el: There was no Maintainer
>>       header -- was that why it didn't deploy?
>
> No: "Author" is used when there's no "maintainer" (actually: "was
> used", since currently that part of the infrastructure is not working).
>
> The problem was in the "Package-Requires" line.  I just fixed it.

Man, you don't realize how much you depend on paredit until you're in a
comment section.

Thanks, as always,
Eric




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn
  2017-08-15 22:29     ` Eric Abrahamsen
@ 2017-08-21 18:04       ` João Távora
  2017-08-22 22:57         ` Eric Abrahamsen
  2017-09-05  9:11       ` Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn) Michael Heerdegen
  1 sibling, 1 reply; 14+ messages in thread
From: João Távora @ 2017-08-21 18:04 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: emacs-devel

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Man, you don't realize how much you depend on paredit until you're in a
> comment section.

Use `M-x electic-pair-mode` instead, works fine in comments :-)

João




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn
  2017-08-21 18:04       ` João Távora
@ 2017-08-22 22:57         ` Eric Abrahamsen
  0 siblings, 0 replies; 14+ messages in thread
From: Eric Abrahamsen @ 2017-08-22 22:57 UTC (permalink / raw)
  To: emacs-devel

joaotavora@gmail.com (João Távora) writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Man, you don't realize how much you depend on paredit until you're in a
>> comment section.
>
> Use `M-x electic-pair-mode` instead, works fine in comments :-)

Maybe I'll try retraining my fingers :)




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn)
  2017-08-15 22:29     ` Eric Abrahamsen
  2017-08-21 18:04       ` João Távora
@ 2017-09-05  9:11       ` Michael Heerdegen
  2017-09-05 13:14         ` Gnu Elpa broken Stefan Monnier
  1 sibling, 1 reply; 14+ messages in thread
From: Michael Heerdegen @ 2017-09-05  9:11 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: emacs-devel

Hi,

seems Gnu Elpa is broken since some days due to ebdb for me: "make"
fails in a fresh checkout of the repository.

Here is what I get:

| elpa> make
| Byte compiling packages/ebdb-i18n-chn/ebdb-i18n-chn.el
| Unable to activate package ‘helm-ebdb’.
| Required package ‘helm-1.0’ is unavailable
| Unable to activate package ‘ebdb-i18n-chn’.
| Required package ‘pyim-1.6.0’ is unavailable
| 
| In toplevel form:
| packages/ebdb-i18n-chn/ebdb-i18n-chn.el:36:1:Error: Cannot open load file: No such file or directory, pyim
| GNUmakefile:178: recipe for target 'packages/ebdb-i18n-chn/ebdb-i18n-chn.elc' failed
| make: *** [packages/ebdb-i18n-chn/ebdb-i18n-chn.elc] Error 1


TIA,

Michael.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05  9:11       ` Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn) Michael Heerdegen
@ 2017-09-05 13:14         ` Stefan Monnier
  2017-09-05 13:28           ` John Wiegley
  2017-09-05 14:44           ` Michael Heerdegen
  0 siblings, 2 replies; 14+ messages in thread
From: Stefan Monnier @ 2017-09-05 13:14 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eric Abrahamsen

> seems GNU ELPA is broken since some days due to ebdb for me: "make"

GNU ELPA (i.e. the archive distribution) is OK, but indeed the elpa.git
checkout can't be directly built without error unless you have helm and
pyim installed.

I use the patch below locally for now.
Haven't yet tried to push this to Eric.


        Stefan


--- a/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
+++ b/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
@@ -1,4 +1,4 @@
-;;; ebdb-chn.el --- China-specific internationalization support for EBDB  -*- lexical-binding: t; -*-
+;;; ebdb-i18n-chn.el --- China-specific internationalization support for EBDB  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2016-2017  Free Software Foundation, Inc.
 
@@ -33,7 +33,7 @@
 
 ;;; Code:
 
-(require 'pyim)
+(when t (require 'pyim))                ;Don't require during compile-time.
 (require 'ebdb-i18n)
 
 (cl-defmethod ebdb-string-i18n ((phone ebdb-field-phone)
diff --git a/packages/helm-ebdb/helm-ebdb.el b/packages/helm-ebdb/helm-ebdb.el
index 63fda85f9..b160ca9e8 100644
--- a/packages/helm-ebdb/helm-ebdb.el
+++ b/packages/helm-ebdb/helm-ebdb.el
@@ -27,8 +27,8 @@
 
 ;;; Code:
 
-(require 'ebdb)
-(require 'helm)
+(require 'ebdb-com)
+(when t (require 'helm))                ;Don't require during compile-time.
 
 (declare-function ebdb-display-records "ext:ebdb-com"
                  (records &optional fmt append select pop buf))





^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 13:14         ` Gnu Elpa broken Stefan Monnier
@ 2017-09-05 13:28           ` John Wiegley
  2017-09-05 14:44           ` Michael Heerdegen
  1 sibling, 0 replies; 14+ messages in thread
From: John Wiegley @ 2017-09-05 13:28 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Eric Abrahamsen, emacs-devel

>>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

SM> I use the patch below locally for now. Haven't yet tried to push this to
SM> Eric.

Thanks for acting on this quickly, Stefan.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 13:14         ` Gnu Elpa broken Stefan Monnier
  2017-09-05 13:28           ` John Wiegley
@ 2017-09-05 14:44           ` Michael Heerdegen
  2017-09-05 15:39             ` Eric Abrahamsen
  2017-09-05 21:57             ` Stefan Monnier
  1 sibling, 2 replies; 14+ messages in thread
From: Michael Heerdegen @ 2017-09-05 14:44 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Eric Abrahamsen, emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I use the patch below locally for now.

FWIW that still gives me

| In toplevel form:
| packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
| GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
| make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1

BTW, does "use [...] locally" mean the server still successfully builds
all packages?

Anyway, thanks for caring.


Michael.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 14:44           ` Michael Heerdegen
@ 2017-09-05 15:39             ` Eric Abrahamsen
  2017-09-05 16:12               ` Eric Abrahamsen
  2017-09-05 21:57             ` Stefan Monnier
  1 sibling, 1 reply; 14+ messages in thread
From: Eric Abrahamsen @ 2017-09-05 15:39 UTC (permalink / raw)
  To: emacs-devel

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> I use the patch below locally for now.
>
> FWIW that still gives me
>
> | In toplevel form:
> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
> | GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
> | make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1

There are three ebdb-* packages in elpa that depend on external packages
that are only found in melpa. I didn't realize that elpa packages
couldn't require melpa packages, though I suppose that makes sense.

I can push patches to all three packages using Stefan's (when t ...)
trick right now.

> BTW, does "use [...] locally" mean the server still successfully builds
> all packages?

I'm also curious why this didn't break right away.

Sorry for making a mess.

Eric




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 15:39             ` Eric Abrahamsen
@ 2017-09-05 16:12               ` Eric Abrahamsen
  0 siblings, 0 replies; 14+ messages in thread
From: Eric Abrahamsen @ 2017-09-05 16:12 UTC (permalink / raw)
  To: emacs-devel

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>> I use the patch below locally for now.
>>
>> FWIW that still gives me
>>
>> | In toplevel form:
>> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
>> | GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
>> | make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1
>
> There are three ebdb-* packages in elpa that depend on external packages
> that are only found in melpa. I didn't realize that elpa packages
> couldn't require melpa packages, though I suppose that makes sense.
>
> I can push patches to all three packages using Stefan's (when t ...)
> trick right now.

Done. Still produces a lot of warnings during the make process, though.




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 14:44           ` Michael Heerdegen
  2017-09-05 15:39             ` Eric Abrahamsen
@ 2017-09-05 21:57             ` Stefan Monnier
  2017-09-05 22:18               ` Eric Abrahamsen
  1 sibling, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2017-09-05 21:57 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Eric Abrahamsen, emacs-devel

>> I use the patch below locally for now.
> FWIW that still gives me
> | In toplevel form:
> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file:
> | No such file or directory, ebdb

That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
it (assuming you configured package.el to look for packages there, of
course).

> BTW, does "use [...] locally" mean the server still successfully builds
> all packages?

ELPA packages are distributed in source form and compiled on the
end-user's system, where package.el's dependency management should
ensure that pyim and helm are installed before he can install
ebdb-i18n-chn and helm-ebdb.

So, those compilation failures don't affect GNU ELPA.


        Stefan



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 21:57             ` Stefan Monnier
@ 2017-09-05 22:18               ` Eric Abrahamsen
  2017-09-05 22:28                 ` Stefan Monnier
  0 siblings, 1 reply; 14+ messages in thread
From: Eric Abrahamsen @ 2017-09-05 22:18 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>> I use the patch below locally for now.
>> FWIW that still gives me
>> | In toplevel form:
>> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file:
>> | No such file or directory, ebdb
>
> That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
> it (assuming you configured package.el to look for packages there, of
> course).

Would he have to run "make externals" before that works?

Shooting in the dark... Anyway let me know if there's something more I
need to do...




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 22:18               ` Eric Abrahamsen
@ 2017-09-05 22:28                 ` Stefan Monnier
  2017-09-06 11:27                   ` Michael Heerdegen
  0 siblings, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2017-09-05 22:28 UTC (permalink / raw)
  To: emacs-devel

>> That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
>> it (assuming you configured package.el to look for packages there, of
>> course).
> Would he have to run "make externals" before that works?

Yes, of course (I just checked: it's mentioned in the README).
But indeed, maybe he just forgot to do that.


        Stefan




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Gnu Elpa broken
  2017-09-05 22:28                 ` Stefan Monnier
@ 2017-09-06 11:27                   ` Michael Heerdegen
  0 siblings, 0 replies; 14+ messages in thread
From: Michael Heerdegen @ 2017-09-06 11:27 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > Would he have to run "make externals" before that works?
>
> Yes, of course (I just checked: it's mentioned in the README).
> But indeed, maybe he just forgot to do that.

Yes, he did (more exactly, I had read the README, but somehow didn't
expect that these steps depend on each other).


Thanks,

Michael.



^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-09-06 11:27 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170815220620.32748.5399@vcs0.savannah.gnu.org>
     [not found] ` <20170815220621.13CA220C81@vcs0.savannah.gnu.org>
2017-08-15 22:23   ` [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn Stefan Monnier
2017-08-15 22:29     ` Eric Abrahamsen
2017-08-21 18:04       ` João Távora
2017-08-22 22:57         ` Eric Abrahamsen
2017-09-05  9:11       ` Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn) Michael Heerdegen
2017-09-05 13:14         ` Gnu Elpa broken Stefan Monnier
2017-09-05 13:28           ` John Wiegley
2017-09-05 14:44           ` Michael Heerdegen
2017-09-05 15:39             ` Eric Abrahamsen
2017-09-05 16:12               ` Eric Abrahamsen
2017-09-05 21:57             ` Stefan Monnier
2017-09-05 22:18               ` Eric Abrahamsen
2017-09-05 22:28                 ` Stefan Monnier
2017-09-06 11:27                   ` Michael Heerdegen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).