From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness
Date: Wed, 20 Mar 2019 21:08:17 -0400 [thread overview]
Message-ID: <jwva7hpm42h.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1sgvh2rcq.fsf@gmail.com> ("João Távora"'s message of "Wed, 20 Mar 2019 21:00:53 +0000")
>> FWIW, I think if basic is fast enough and flex is 2x slower, then flex
>> is likely fast enough as well (or the contrapositive: if flex is too
>> slow and basic is only 2x faster, then basic is also too slow).
>
> Hmmm, slightly confused, but I think we're currently in the
> "contrapositive" side (at least given the UI problems that I describe
> below). Anyway, this is orthogonal, but I do think that flex can be
> made faster so that it is only, say 1.2x, slower than basic in the worst
> case. I'd say it's worth a shot. Depending on the "basic"
> implementation, it could even be faster.
What I'm saying is that a slowdown of 2x is basically irrelevant here:
it's fast enough (maybe those rare people running on really slow machine
will simply not enable it, but I'm not worried).
> I don't understand: while-no-input _is_ there, at least it is doing that
> which I was going to attempt.
I thought you wanted to replace the icomplete-delay with while-no-input,
rather than just add while-no-input. Sorry.
> If somehow while-no-input were able to detect interruptions at a more
> finer grained level, I think icomplete-completions would be interrupted
> earlier. A (dumb) way to fix this is by simply adding a call to
> input-pending-p to one of the critical sections:
If it takes 2s to notice input, maybe it's a bug. These things depend
on the OS you're running (IIRC we're much less good at it under MacOS),
but it's worth reporting it.
Stefan
next prev parent reply other threads:[~2019-03-21 1:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190213212413.868.40960@vcs0.savannah.gnu.org>
[not found] ` <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org>
2019-02-14 12:38 ` master e4896fc 1/2: Add a new 'flex' completion style Robert Pluim
2019-02-14 13:50 ` João Távora
2019-02-14 14:37 ` Eli Zaretskii
2019-02-14 14:40 ` João Távora
2019-02-14 14:47 ` Robert Pluim
2019-02-14 14:50 ` João Távora
2019-02-14 15:12 ` Robert Pluim
2019-02-14 15:22 ` Drew Adams
2019-02-14 14:29 ` Eli Zaretskii
2019-02-14 14:39 ` João Távora
[not found] ` <20190213212415.148B9209D7@vcs0.savannah.gnu.org>
2019-03-16 1:13 ` [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness Dmitry Gutov
2019-03-16 13:02 ` João Távora
2019-03-16 13:19 ` Stefan Monnier
2019-03-16 14:25 ` João Távora
2019-03-17 18:06 ` Dmitry Gutov
2019-03-17 19:22 ` João Távora
2019-03-17 20:32 ` Dmitry Gutov
2019-03-17 21:46 ` João Távora
2019-03-18 14:26 ` Dmitry Gutov
2019-03-18 14:42 ` Dmitry Gutov
2019-03-18 14:49 ` Stefan Monnier
2019-03-18 14:52 ` Dmitry Gutov
2019-03-18 16:20 ` Stefan Monnier
2019-03-18 15:13 ` Who uses Icomplete-mode? " João Távora
2019-03-18 16:44 ` Stefan Monnier
2019-03-18 21:08 ` Who uses Icomplete-mode? Juri Linkov
2019-03-18 14:54 ` [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness João Távora
2019-03-18 14:51 ` João Távora
2019-03-18 17:18 ` Dmitry Gutov
2019-03-20 9:59 ` João Távora
2019-03-20 12:09 ` Stefan Monnier
2019-03-20 21:00 ` João Távora
2019-03-20 21:58 ` Dmitry Gutov
2019-03-20 23:25 ` João Távora
2019-03-21 1:14 ` Stefan Monnier
2019-03-21 1:20 ` Dmitry Gutov
2019-03-21 1:08 ` Stefan Monnier [this message]
2019-03-17 17:51 ` Dmitry Gutov
2019-03-17 19:09 ` João Távora
2019-03-17 20:22 ` Dmitry Gutov
2019-03-17 21:27 ` João Távora
2019-03-18 0:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva7hpm42h.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).