From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Thu, 11 Apr 2019 16:32:50 -0400 Message-ID: References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197764"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 11 22:33:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEgNb-000pDa-Mb for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 22:33:04 +0200 Original-Received: from localhost ([127.0.0.1]:54581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEgNZ-0001Kn-QZ for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 16:33:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEgNR-0001Kb-Cv for emacs-devel@gnu.org; Thu, 11 Apr 2019 16:32:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEgNQ-0000du-HM for emacs-devel@gnu.org; Thu, 11 Apr 2019 16:32:53 -0400 Original-Received: from mail01.iro.umontreal.ca ([132.204.25.201]:44460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEgNQ-0000dY-7g for emacs-devel@gnu.org; Thu, 11 Apr 2019 16:32:52 -0400 Original-Received: from mail01.iro.umontreal.ca (mail01.iro.umontreal.ca [127.0.0.1]) by mail01.iro.umontreal.ca (Postfix) with ESMTP id 8317984B69E8 for ; Thu, 11 Apr 2019 16:32:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; h=content-type:content-type:mime-version:user-agent:in-reply-to :date:date:references:message-id:subject:subject:to:from:from; s=dkim; t=1555014771; x=1555878772; bh=CDQaTEElJep18cO1tV2HjYrS ct0Z55eTXgx57dg9EOA=; b=g1ay4iVD8cXLz1d6nFzRIJkZpgNtoPieooHlmuJ5 tA7uO0IFqaBKqbKM8bK5GDLLFWqankDQE1FXPV1xQlB+V3rN+MD0EB0JAa5MVs/n YbPvmShGOLGkMJgUfew+RHweFKjecSVMDgltqIf95KmQUAA03EgwSpZC23HUT4aO k1HWxZLzDl0ios4kIBfmY+L5dtvtVYkUqmgR+Z5dbLS2K1vff1urbCkS1NK/VAcf bTlJ+D4EntIa5yAVrHVlimJ1yFJ9UCkG93YN79rekaAnXUgDERQfECkF1b4L0SoF d5+FEA5W07vtBWySosq5GLx086KL+5/TTqSuJd1JZu1qsw== X-Virus-Scanned: amavisd-new at iro.umontreal.ca Original-Received: from mail01.iro.umontreal.ca ([127.0.0.1]) by mail01.iro.umontreal.ca (mail01.iro.umontreal.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ty6ZuZYH9zWj for ; Thu, 11 Apr 2019 16:32:51 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPS id B750C84B69D1; Thu, 11 Apr 2019 16:32:50 -0400 (EDT) In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.201 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235308 gmane.emacs.orgmode:124151 Archived-At: > The third is why indent-according-to-mode hard-codes the check for > indent-relative and indent-relative-first-indent-point. Wouldn't it be > nice if this check instead looked up some variable akin to > electric-indent-functions-without-reindent, that can be more easily > customised? Agreed. Comparing functions is always fraught with dangers, as we are witnessing here (this very fundamental problem was arguably the original motivation for inventing type-classes in Haskell to avoid the ugly ad-hoc "eqtypes" of SML). We need the comparison here for backward compatibility, but we should supplement it with a variable, like we did with `electric-indent-inhibit` (and not with electric-indent-functions-without-reindent which just suffers from the same fundamental problem). Stefan