From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Few enhancements to ansi-term Date: Tue, 30 Apr 2019 14:34:48 -0400 Message-ID: References: <87wojbz9x9.fsf@gmail.com> <87v9yvz9sn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175484"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 30 20:35:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLXav-000jRz-Kd for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 20:35:09 +0200 Original-Received: from localhost ([127.0.0.1]:51620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLXau-0000SY-H1 for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 14:35:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLXao-0000R6-5v for emacs-devel@gnu.org; Tue, 30 Apr 2019 14:35:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLXal-0006lL-FH for emacs-devel@gnu.org; Tue, 30 Apr 2019 14:35:02 -0400 Original-Received: from [195.159.176.226] (port=47146 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLXal-0006ka-6Z for emacs-devel@gnu.org; Tue, 30 Apr 2019 14:34:59 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hLXaj-000j8p-2g for emacs-devel@gnu.org; Tue, 30 Apr 2019 20:34:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:lVVlrFr9IvIiphJamkFDMkggc78= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236065 Archived-At: > * lisp/term.el (term-set-scroll-region): Do not set > term-scroll-with-delete when the region is set to the height of the > terminal. > * lisp/term.el (term-reset-terminal): Reset term-scroll-with-delete. Better write these as: > * lisp/term.el (term-set-scroll-region): Do not set > term-scroll-with-delete when the region is set to the height of the > terminal. > (term-reset-terminal): Reset term-scroll-with-delete. [ I read the first entry and thought the next was about another file so I didn't even look at it. ] The patch also changes term-reset-size but the ChangeLog doesn't explain what this change does. > @@ -3439,7 +3440,7 @@ term-set-scroll-region > (setq term-scroll-with-delete > (or (term-using-alternate-sub-buffer) > (not (and (= term-scroll-start 0) > - (= term-scroll-end term-height))))) > + (= term-scroll-end (1- term-height)))))) The code just above does: (setq term-scroll-end (if (or (<= bottom term-scroll-start) (> bottom term-height)) term-height bottom)) Should this also be changed to (1- term-height)? And/or should the test use <= as in: (not (and (<= term-scroll-start 0) (>= term-scroll-end (1- term-height)))))) ? > * lisp/term.el (term-unwrap-line, term-emulate-terminal): Add > rear-nonsticky text property to the newlines used for line wrapping. The diff basically say that already, so I'd rather write it as "Prevent the `term-line-wrap` property of newlines from spreading accidentally when inserting text next to it" or something like that. As for the code, it looks good to me. Stefan