unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg
Date: Tue, 04 Jun 2019 09:15:31 -0400	[thread overview]
Message-ID: <jwva7exh4xl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAA01p3qsaOfMDkk=mmhA4SCeMpDp39FVuBq6D8fxT=ZFr0u_8A@mail.gmail.com> (Oleh Krehel's message of "Tue, 4 Jun 2019 11:00:28 +0200")

> There's already existing message.el code that sets
> `message-inhibit-body-encoding' to t.  But if the encoding is
> inhibited, we should not assert if Unicode was not encoded.

So from your description I think indeed this has nothing to do with
Unicode: the code you changed doesn't "assert if Unicode was not
encoded".  It asserts that the text was not encoded.  Unicode or
anything else.  German umlauts are chars that indeed appear in the
Unicode charset, but they also appear in many other charsets (such as
latin1).

"Encoding" turns chars into bytes and the test verifies that there are
only bytes left.  


        Stefan




      reply	other threads:[~2019-06-04 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190603135626.32064.50250@vcs0.savannah.gnu.org>
     [not found] ` <20190603135628.1D13220AD1@vcs0.savannah.gnu.org>
2019-06-03 17:16   ` [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg Stefan Monnier
2019-06-04  9:00     ` Oleh Krehel
2019-06-04 13:15       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva7exh4xl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).