From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: cedet Date: Fri, 14 Jun 2019 15:16:25 -0400 Message-ID: References: <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219042"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 21:18:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbriE-000ulm-Kh for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 21:18:10 +0200 Original-Received: from localhost ([::1]:54548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbriD-0002Oz-AI for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 15:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38813) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbrgc-0002Ne-H7 for emacs-devel@gnu.org; Fri, 14 Jun 2019 15:16:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbrgb-0000yA-IB for emacs-devel@gnu.org; Fri, 14 Jun 2019 15:16:30 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbrgb-0000xV-9n for emacs-devel@gnu.org; Fri, 14 Jun 2019 15:16:29 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 827628116F; Fri, 14 Jun 2019 15:16:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5735780B53; Fri, 14 Jun 2019 15:16:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560539787; bh=s7cQgqCYBYYbShxgIi3/CemkPfHkPOC30iRc01nYW98=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hTE4vVPBVkt/4txvFsRcsva1sjrxwruRQnCOWQWOnPuzF6rjLxu/Gzk0bO4S14P4Q 1Uf/MtnqQhOQoGneVw0fIuEKEo5V/5fKf5Vc2f4CDfRWJvDmHdHtfJY13aVi2g3y0d qIugAO/f3wPGq0aBv6TB4Q7WKBsmApfqguaVB49GMyMjm3wAjHkwDL/3yOKoho9DNm f8U290zXB/RKoBQK+NiEPC0wxWTxW3KGAGO0eMBH5nD9GGrmh7evCnImRPGhZCI1YK FSZ3R2IozTTy8TZJJ9wbsH5ilmyqwG46xOmY0bVh97rhPK0K1ytmu+t76EUkxrWuj1 ATRrkNvz4a7Vw== Original-Received: from alfajor (cm-84.215.66.78.getinternet.no [84.215.66.78]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD8B612023B; Fri, 14 Jun 2019 15:16:26 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 14 Jun 2019 16:10:14 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237637 Archived-At: >>> I'll go through all the warnings emitted and adjust the >>> oref/oset/slot-value calls and push after I've figured out how to >>> actually test this stuff. I mean, it looks like it should be a >>> semi-mechanical replacement situation, but I hate not testing these >>> things... >> >> The non-mechanical part is to look for the :initarg to see if >> indeed : is the init arg for the slot. >> This is *usually* the case, but it's just a coding convention, > > I grepped through :initarg in cedet, and it looks like there's only one: > > (max-tags-initial :initarg max-tags-initial > > And my changes didn't change any of the call sites... Then I guess you can just remove the `:`s and be done with it. Stefan