From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change Date: Tue, 01 Oct 2019 11:08:31 -0400 Message-ID: References: <20191001144135.32717.19241@vcs0.savannah.gnu.org> <20191001144137.1032C20927@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211417"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 01 17:08:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFJlc-000suA-30 for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 17:08:44 +0200 Original-Received: from localhost ([::1]:43162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFJla-0007h4-SA for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 11:08:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43554) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFJlV-0007gy-EQ for emacs-devel@gnu.org; Tue, 01 Oct 2019 11:08:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFJlU-0002nR-2T for emacs-devel@gnu.org; Tue, 01 Oct 2019 11:08:36 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42799) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFJlT-0002nB-R8 for emacs-devel@gnu.org; Tue, 01 Oct 2019 11:08:36 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0AA48448884; Tue, 1 Oct 2019 11:08:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ED8B3448882; Tue, 1 Oct 2019 11:08:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1569942514; bh=vJ+gtJ0VZd3NRrpG29TnCuUcatjNYBH+KIX3OaExWdo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XrvUj0Xzvz4FxZZ4Y3+pMJm44E6rVMg7yqMVD85iXFnEgTBk1PkimHnCVfyLcRo1/ GL8lCm1fb6x5Lm1JVqn6Rzi4dRdG3uO2p9+QuaUAuJMaIVSK1L89QH7Yt4I5AZd/Ll ptU6YB/wDL1R493UUQEgO7wvQ7SJTqymdZAwWwMyPtrTouzsMPjlDqFMeMOASXmwaS jp5RVEnILiM0CYCeSRceta7FPSgpzGgjYxkrUHqQltFSm3fGFnJlmKsIhBGceSMso3 83BegrURcmNZyYQZDC3fOw35ZeA2QlvPJm6HDkuF6cDRl1M85jOjEA9cHByrFKFits 3mMUsnlC2/lnQ== Original-Received: from pastel (107-179-151-143.cpe.teksavvy.com [107.179.151.143]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 84DC2120A8E; Tue, 1 Oct 2019 11:08:33 -0400 (EDT) In-Reply-To: <20191001144137.1032C20927@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 1 Oct 2019 10:41:36 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240443 Archived-At: Hi Lars, > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -124,7 +124,7 @@ > (require 'backquote) > (require 'macroexp) > (require 'cconv) > -(eval-when-compile (require 'compile)) > +(require 'compile) This is a bad change. It brings in many more packages, and every additional package brought in reduces the quality of our warnings (e.g. if any of the packages (transitively) loaded load cl-lib, then we fail to signal when a package uses cl-lib functionality without requiring cl-lib). We should try and find some other solution. Stefan