From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Tue, 03 Dec 2019 11:01:17 -0500 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143046"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juanma Barranquero , Emacs developers To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 03 17:20:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icAuX-000b2R-HX for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 17:20:25 +0100 Original-Received: from localhost ([::1]:55706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icAuV-0006Wq-Nu for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 11:20:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34932) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icAcG-00053e-7E for emacs-devel@gnu.org; Tue, 03 Dec 2019 11:01:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icAcC-0002Kr-SK for emacs-devel@gnu.org; Tue, 03 Dec 2019 11:01:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47382) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icAcC-0002Hw-Iy for emacs-devel@gnu.org; Tue, 03 Dec 2019 11:01:28 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8E90644A619; Tue, 3 Dec 2019 11:01:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1479744A5FE; Tue, 3 Dec 2019 11:01:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1575388885; bh=shYs4EA/kFthOhgsZNg8q1TpOu/gmsa+JLSnODOZDv8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=W7gERws9uSljuvIcKpaH89uC1KLBsvnwX4jEWPv3lVdPv9K0nzdLH/u7DIa/FWJou Op+0eh13ZvXLbAzIgXT9GmsXvjp7kRx3mubdJaOHpOKXASbo75Jy3GEkvMV7WwsMID GPFr+28oZgEMZQWl4LMvxOoRig666vE2oaLTvx2QGbqroW8QDZwzPJwWnjlCL3bGMM L/SCjqEoQgaAMU0nghTYcKkQMyJmNlwveaKYpx3AVVvFQmy1ozekRU36bHLZx2aybd JQ66cxGPTx2NuDq3JTocWe4kAtNqQbuMxssLGFSZx4hOppALvDrgqL75zY5ofKI/30 2R0RD6G+8n2Eg== Original-Received: from alfajor (unknown [45.72.228.205]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB3D8121045; Tue, 3 Dec 2019 11:01:24 -0500 (EST) In-Reply-To: <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> ("Mattias \=\?windows-1252\?Q\?Engdeg\=E5rd\=22's\?\= message of "Tue, 3 Dec 2019 16:33:58 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243054 Archived-At: >> I'd rather fix the code not to rely on the return value. > I'm sure a lot more code relies on the return value of 'push'. Probably, but I still think it's bad practice to use the return value of an operation which is fundamentally a side-effect. Stefan