unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Raffael Stocker <r.stocker@mnet-mail.de>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: scanner
Date: Fri, 10 Apr 2020 14:13:37 -0400	[thread overview]
Message-ID: <jwva73jw6y5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871rov7dmc.fsf@mnet-mail.de> (Raffael Stocker's message of "Fri,  10 Apr 2020 14:02:19 +0200")

> I have made a simple document scanning package that I would like to
> contribute to ELPA.  The source can be found here:
> https://gitlab.com/rstocker/scanner.git

Thanks, added.

Beside some technical details I had to tweak as part of the addition,
I noticed another problem: you add a submenu to the global menus (which
I guess is fine), but some of the commands in that menu are not
autoloaded so selecting them signals an error.  You should probably
"disable/grey" them until the package is loaded, or add autoloads, or
...

I'm also wondering why you need all those `:key-sequence nil` in the menu.
Maybe it reflects a bug in our code?


        Stefan




  reply	other threads:[~2020-04-10 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 12:02 [ELPA] New package: scanner Raffael Stocker
2020-04-10 18:13 ` Stefan Monnier [this message]
2020-04-10 19:58   ` Raffael Stocker
2020-04-10 20:20     ` Raffael Stocker
2020-04-10 20:44       ` Stefan Monnier
2020-04-10 20:43     ` Stefan Monnier
2020-04-10 21:17       ` Raffael Stocker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva73jw6y5.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=r.stocker@mnet-mail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).