From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Move 'with-buffer-modified-unmodified' to simple.el
Date: Fri, 18 Sep 2020 15:56:54 -0400 [thread overview]
Message-ID: <jwva6xmhngf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <D3BA143E-E928-4CED-A5A7-CA9A2DBDF60F@gmail.com> (Yuan Fu's message of "Fri, 18 Sep 2020 14:25:25 -0400")
> How should we determine if the extra bindings in `with-silent-modifications’
> aren’t right? In my understanding `with-silent-modifications’ should only be
> used when changing text properties and if you actually insert something you
> should use `with-buffer-modified-unmodified’. Is that correct?
I think so, yes.
> Looking though the result of the grep, I see some text property changes and
> some content changes.
How many cases (approximately) involve content changes?
> But the content changes seems to appear in program-generated buffers
> so I’m not sure if `with-silent-modifications’ would do any
> harm anyway.
`with-silent-modifications’ would prevent jit-lock from doing its job,
so it would interfere with the use (within that buffer) of any package
that depends on jit-lock, such as font-lock-mode, nlinum-mode,
nhexl-mode, goto-address-mode, bug-reference-mode, glasses-mode.
Stefan
next prev parent reply other threads:[~2020-09-18 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 23:12 Move 'with-buffer-modified-unmodified' to simple.el Yuan Fu
2020-09-17 3:11 ` Stefan Monnier
2020-09-18 18:25 ` Yuan Fu
2020-09-18 19:56 ` Stefan Monnier [this message]
2020-10-01 16:24 ` Yuan Fu
2020-10-01 16:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6xmhngf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).