From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 02/16] Assert not local-variable-p after setq in let_default binding Date: Wed, 25 Nov 2020 15:54:11 -0500 Message-ID: References: <20201119153814.17541-1-sbaugh@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36124"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Arnold Noronha , Dmitry Gutov , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 25 21:54:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki1oS-0009Jd-JI for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 21:54:52 +0100 Original-Received: from localhost ([::1]:51122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki1oR-0006mv-M6 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 15:54:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1nu-0006IE-35 for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:54:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1ns-0002NK-6O for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:54:17 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AAC810022E; Wed, 25 Nov 2020 15:54:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A4AD81001CB; Wed, 25 Nov 2020 15:54:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606337653; bh=ZfvG4HefFHBGfA8tDttBezjYWlM4xbpiWxu9LtS3+Vc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GwHnbX+KTQ3HT+hJHOyWUhR50M6PIXY4mVc4sksNk4Bef9DymQXYTECjeLw2ENVWg X+TQKI7hln0b/PYRYxYO877u2cEwmVsBPbrVTJuDg7FSvkhfltt8bsWCI0WEThEk+z 6syLyRWicKFmnWfw0TfJwlFJ9srNLT3ujw1ftDVBHVb9lrsDvRMAwdSdnVlvTFGDT9 7WFWKHm8O5Zjes1Myp7/YWBiJtv0OTMxcZoUcF4V3L90BYc10dhWLyC9TjPBwq7/J0 LIJ+rP3IZ2ukjmunnN6A+pL7UvNsbrP1c4g0IJysyE4kSymzu1KHlmJO6YFJfq1vR5 1vGOWvya0wj9A== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5CDF112044C; Wed, 25 Nov 2020 15:54:13 -0500 (EST) In-Reply-To: (Spencer Baugh's message of "Sat, 21 Nov 2020 21:34:31 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259810 Archived-At: > diff --git a/test/src/data-tests.el b/test/src/data-tests.el > index 7e69b9c331..7c403870f1 100644 > --- a/test/src/data-tests.el > +++ b/test/src/data-tests.el > @@ -358,6 +358,7 @@ comparing the subr with a much slower lisp implementation." > (should (equal (symbol-value var) 42)) > (should (equal (default-value var) (symbol-value var))) > (set var 123) > + (should (not (local-variable-p var))) > (should (equal (symbol-value var) 123)) > (should (equal (default-value var) (symbol-value var)))) ;bug#44733 > (should (equal (symbol-value var) def)) LGTM, Stefan