From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master fd92023: Make checkdoc work with qualified methods Date: Thu, 04 Mar 2021 18:23:22 -0500 Message-ID: References: <20210304203118.27982.28704@vcs0.savannah.gnu.org> <20210304203120.17C8C20E1B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 05 00:24:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHxKK-0009os-3c for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Mar 2021 00:24:16 +0100 Original-Received: from localhost ([::1]:48718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHxKJ-0001iY-5U for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 18:24:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHxJc-0001IV-Ax for emacs-devel@gnu.org; Thu, 04 Mar 2021 18:23:33 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHxJY-0003gH-3y for emacs-devel@gnu.org; Thu, 04 Mar 2021 18:23:31 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 480098081F; Thu, 4 Mar 2021 18:23:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0833780229; Thu, 4 Mar 2021 18:23:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614900204; bh=JjySHCKPOlDHLy3HhvbNz2howPn20Vb1UC3kn37oLnY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WAyZt/nDhap4pjhULelo52PedvOE1nIb0XXaaerp/Bsr5Jl6o7xc4q703YTPXhb5l LQGqjXwIPWbMzO1QLbnyEy6chNaTGReQZ5A8k0rvFd4yo1N1xbfkvt+KZ5SyikOl8H y3hf0zJxlRuZNCSZLEkX+HC+iqfc7ZzFAec33qUSHLw1IHYYnKrnrkqvGLmeaR1Zqq ffiYia5PW+X819Hnd8/gpoo6mjjn2qF9t4KVkS/lY38PBRIMJulUrXOSmq0ZfVLUcN C36sHbjen/rigszzCtkxkcWUhr6WfWm6jzPAjP9GuQqf6qTu/31HAP9MBuwzcwwc6Q L3lVZs8PrcjWw== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C959E12034D; Thu, 4 Mar 2021 18:23:23 -0500 (EST) In-Reply-To: <20210304203120.17C8C20E1B@vcs0.savannah.gnu.org> (Mauro Aranda's message of "Thu, 4 Mar 2021 15:31:19 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265996 Archived-At: > Make checkdoc work with qualified methods > > * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring): Handle > cl-defmethod in a case of its own. Check for the presence of > qualifiers, and skip them accordingly until the docstring. Any chance we could use the `doc-string-elt` property (which I just fixed for `cl-defmethod`) for `checkdoc--next-docstring`? Stefan