From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Thu, 25 Mar 2021 10:05:50 -0400 Message-ID: References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Michael Albinus , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 15:15:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPQlg-0007bO-UF for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 15:15:24 +0100 Original-Received: from localhost ([::1]:35702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPQlf-0003cm-Ui for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 10:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPQcV-00013w-L2 for emacs-devel@gnu.org; Thu, 25 Mar 2021 10:05:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPQcT-0004fh-Rl for emacs-devel@gnu.org; Thu, 25 Mar 2021 10:05:55 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2E439440CCA; Thu, 25 Mar 2021 10:05:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C50EB440970; Thu, 25 Mar 2021 10:05:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616681151; bh=sIiDo2GqXTTkmPrpsjQOkqjkj6u9EdB4rcMFmGhNQNM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BmQYl9w/iwb2EI7WK9ZFXGEHOTVxS+x7/V8ijJ8jPR3cqQ6aubtuspqcxtiBP50vI SmHwGKzpUsHpzSACZq8OwPRwx+NS7pJDmDnAMe7MeoV6dBhWvt2p2/rcmY2flbu8mo vYUVvXSuLtP7ze0hW1mARg7BS9tQmIVUnaihzybnUtt3wyNVflfQIFXQ58IsHOTXqV PWwvNuiRckWxDCvl/mCFeunkuKSoKaGd9wUhrsLRGBr1mPv2pGQtJdLKKHzKx6CAEw YeR7kvzvUkRqAEepDFakKSctOt7zJMCT5EFnxLGvBnQ85gCyOQOtm/kBB1WX085YcY 43SOawYEfM0Hg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ECE5412034D; Thu, 25 Mar 2021 10:05:50 -0400 (EDT) In-Reply-To: <878s6ba96u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 25 Mar 2021 10:12:25 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267018 Archived-At: > What's the performance impact here? This is going to be called a whole > bunch of times when the user hits TAB... It should be OK to do the condition-case wrapping around the loop rather than within it, so the performance impact should be negligible. > I'm also not quite sure why we should be ignoring these errors -- > they're code errors, like any others, and shouldn't be expected to > fail, should they? The purpose is to make sure people can still `M-x` even in the presence of such errors. They *should* never happen, but an error there shouldn't render Emacs unusable ;-) Stefan