unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org,  gregory@heytings.org,  emacs-devel@gnu.org
Subject: Re: master daea9b3 1/2: Read mailcaps again only when necessary
Date: Mon, 01 Nov 2021 17:07:12 -0400	[thread overview]
Message-ID: <jwva6inh9mq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83h7cvln71.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Nov 2021 20:56:18 +0200")

> That's why I think we should also record the size and the inode, and
> we probably should do that before taking file-truename.  The latter is
> just for recording.

There's a case to be made to just store most of the output of
`file-attributes`, indeed, instead of just the modification time.

> Of course, the situation you described is also highly improbable: why
> should the same program care about two files in exactly that sequence
> as to make your point for you?  What are the chances of that?

Maybe it's highly unlikely, indeed.

But I don't see what's the benefit of calling `file-truename`: I know it
makes it slower and introduces an (unlikely) broken corner case, but
what's the upside?


        Stefan




  reply	other threads:[~2021-11-01 21:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211101135344.25800.81476@vcs0.savannah.gnu.org>
     [not found] ` <20211101135346.2EBEB20B72@vcs0.savannah.gnu.org>
2021-11-01 16:56   ` master daea9b3 1/2: Read mailcaps again only when necessary Stefan Monnier
2021-11-01 17:01     ` Lars Ingebrigtsen
2021-11-01 17:19       ` Eli Zaretskii
2021-11-01 17:21         ` Lars Ingebrigtsen
2021-11-01 17:24           ` Eli Zaretskii
2021-11-01 17:29             ` Lars Ingebrigtsen
2021-11-01 18:13               ` Eli Zaretskii
2021-11-01 18:35                 ` Stefan Monnier
2021-11-01 18:56                   ` Eli Zaretskii
2021-11-01 21:07                     ` Stefan Monnier [this message]
2021-11-02 12:54                       ` Eli Zaretskii
2021-11-02 13:51                         ` Stefan Monnier
2021-11-01 18:20               ` Stefan Monnier
2021-11-01 18:31                 ` Eli Zaretskii
2021-11-01 18:06       ` Stefan Monnier
2021-11-01 18:48         ` Lars Ingebrigtsen
2021-11-01 18:50           ` Stefan Monnier
2021-11-01 19:04             ` Lars Ingebrigtsen
2021-11-01 21:31               ` Stefan Monnier
2021-11-02 14:54                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6inh9mq.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).