From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Early backtrace. Date: Tue, 11 Jan 2022 09:47:34 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 15:49:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7ISv-0009lL-Ec for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 15:49:37 +0100 Original-Received: from localhost ([::1]:51650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7ISu-0006LZ-Hb for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 09:49:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7IR9-0004Ay-Bi for emacs-devel@gnu.org; Tue, 11 Jan 2022 09:47:49 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7IR2-0000c6-4x for emacs-devel@gnu.org; Tue, 11 Jan 2022 09:47:46 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AB2914422A1; Tue, 11 Jan 2022 09:47:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 277EE442299; Tue, 11 Jan 2022 09:47:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641912456; bh=jhGwQiezegrZDawXyVVbxygvePn7B3mhSFb1bAbkS3Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZN0Hdr/0u0gMplmYQS827ZYA5uBaRY1ohjGMmi0OgU8WwMPa1a10f8dBlXXmvkG51 RQo6nzVc5L0OcnHqh074//pL/SSVmMLcSWZMUnfh73G8Sq4+p7R+gerTpaU4PywcBc e6BZ9v4yf5VlWky5tbT5w5PfDVkIp2EjVstcVbWMJoLfxelJW5bYLOASTxwJNrbUF3 j54qT3ZbSzmOaUeBzfXmp+yDM5UOgWZV1OyyZNU79CI1lkO7uwOnJqa/9pWYqj39XF 7yS2tZeHP6hyyMNatGieMLiVLnj8+3slL/SA4vfRqbSJmZy1mWB39WIhX+suExYHuu X98BnQLi7ofsA== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C4153120384; Tue, 11 Jan 2022 09:47:35 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Tue, 11 Jan 2022 11:36:32 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284607 Archived-At: >> I have a similar hack here for the same reason ;-) >> So a +1 from me (tho I'd recommend using the `debugger-` namespace >> rather than `early-`). > > Thanks! Maybe `debug-early' and `backtrace-early' would do for the two > functions? There isn't really a debugger- prefix that early in the > bootstrap. Namespace prefixes don't need to be created before we use them. The point is just that `debugger-` is already used by definitions (in `debug.el`) so we can reuse that space instead of messing up pristine real estate. > No, inside signal_or_quit, Vdebugger gets bound to Qdebug, so as to > bypass the setting made in ERT. Also it is filtered out by checking for > not being in dump or bootstrap. Instead, we should check Ffboundp > (Qdebug) || Ffboundp (Qdebug_early). Not difficult to do. Oh, god, I didn't know (or forgot) about that horror. We should throw it out: your code should make it obsolete. E.g. we can take your new code as the default value of `debugger` and only replace it with `#'debugger` when an interactive frame is available. Stefan