unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Early backtrace.
Date: Tue, 11 Jan 2022 09:47:34 -0500	[thread overview]
Message-ID: <jwva6g21gfw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <Yd1rwCQvv73YEENp@ACM> (Alan Mackenzie's message of "Tue, 11 Jan 2022 11:36:32 +0000")

>> I have a similar hack here for the same reason ;-)
>> So a +1 from me (tho I'd recommend using the `debugger-` namespace
>> rather than `early-`).
>
> Thanks!  Maybe `debug-early' and `backtrace-early' would do for the two
> functions?  There isn't really a debugger- prefix that early in the
> bootstrap.

Namespace prefixes don't need to be created before we use them.
The point is just that `debugger-` is already used by definitions (in
`debug.el`) so we can reuse that space instead of messing up pristine
real estate.

> No, inside signal_or_quit, Vdebugger gets bound to Qdebug, so as to
> bypass the setting made in ERT.  Also it is filtered out by checking for
> not being in dump or bootstrap.  Instead, we should check Ffboundp
> (Qdebug) || Ffboundp (Qdebug_early).  Not difficult to do.

Oh, god, I didn't know (or forgot) about that horror.
We should throw it out: your code should make it obsolete.
E.g. we can take your new code as the default value of `debugger` and
only replace it with `#'debugger` when an interactive frame
is available.


        Stefan




  reply	other threads:[~2022-01-11 14:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 20:34 Early backtrace Alan Mackenzie
2022-01-10 21:54 ` Stefan Monnier
2022-01-11 11:36   ` Alan Mackenzie
2022-01-11 14:47     ` Stefan Monnier [this message]
2022-01-30 11:07       ` [PATCH]: " Alan Mackenzie
2022-01-30 16:31         ` Stefan Monnier
2022-01-31 14:04           ` Stefan Monnier
2022-02-01 19:14           ` Alan Mackenzie
2022-02-02  3:36             ` Stefan Monnier
2022-02-02 20:38               ` Alan Mackenzie
2022-02-02 20:59                 ` Stefan Monnier
2022-02-03  8:38                   ` Eli Zaretskii
2022-02-03 21:35                     ` Alan Mackenzie
2022-02-04  7:24                       ` Eli Zaretskii
2022-02-04 21:01                         ` Alan Mackenzie
2022-02-05  7:12                           ` Eli Zaretskii
2022-02-05 10:48                             ` Alan Mackenzie
2022-02-04 13:31                     ` Stefan Monnier
2022-02-04 14:02                       ` Eli Zaretskii
2022-01-31  9:30         ` Philipp Stephani
2022-01-31 12:42           ` Eli Zaretskii
2022-01-31 16:54             ` Alan Mackenzie
2022-01-31 17:24               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6g21gfw.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).