From: Stefan Monnier <monnier@iro.umontreal.ca>
To: JD Smith <jdtsmith@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: compile.el error properties: buffer as filename not working
Date: Sat, 12 Feb 2022 17:42:15 -0500 [thread overview]
Message-ID: <jwva6evn20k.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <9894DE9A-1DBD-45D7-A0D0-1D92E022507C@gmail.com> (JD Smith's message of "Mon, 31 Jan 2022 23:07:19 -0500")
> 1. In `compilation-error-properties’,
> `compilation-transform-file-match-alist’ is matched against a nil
> filename, since the definition of that filename looks like (note
> the bufferp):
>
> (let ((file-name
> (and (consp file)
> (not (bufferp (car file)))
> (if (cdr file)
> (expand-file-name (car file) (cdr file))
> (car file)))))
>
> This seems to have been fixed using a when-let in the Emacs 28 branch (unconfirmed).
> 2. `compilation-get-file-structure’ is called with the file list, but
> this function does not expect a (buffer), and calls (e.g.)
> file-name-absolute-p(#<buffer boo.py>), resulting in an error.
Any chance you can provide a recipe or a backtrace?
Also it might be useful to provide some context, such as which package
uses this ability to return a buffer.
Stefan
next prev parent reply other threads:[~2022-02-12 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 4:07 compile.el error properties: buffer as filename not working JD Smith
2022-02-12 22:42 ` Stefan Monnier [this message]
2022-02-13 14:20 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6evn20k.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jdtsmith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).