From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs 29 expand command in minibuf Date: Tue, 21 Jun 2022 16:31:02 -0400 Message-ID: References: <87r13txi5a.fsf@gnu.org> <878rq0yg9g.fsf@rub.de> <868rpvaqdr.fsf@stephe-leake.org> <87v8syquog.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24881"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stephen Leake , Stephen Berman , hx , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 21 22:32:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3kY5-0006Eo-IC for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Jun 2022 22:32:33 +0200 Original-Received: from localhost ([::1]:42612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3kY3-0002DV-Pq for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Jun 2022 16:32:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3kWw-0001Wf-6S for emacs-devel@gnu.org; Tue, 21 Jun 2022 16:31:22 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3kWp-0007B4-PL; Tue, 21 Jun 2022 16:31:17 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9DA6C80723; Tue, 21 Jun 2022 16:31:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 94D2E8004C; Tue, 21 Jun 2022 16:31:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655843466; bh=zuME7tkExiYyP0uO1o0oglSr3AdCidSOAY3T61dHv74=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UKVIkOR6sMhaYszajsqpXhfCE1N66Ww0BEgquJZvObXlyqIM/1iq6CUa5lgh4dUzh wR0tqIRAhO7rStgIYf/QXS17lcqhIcx2Cm8xxfz5tbMTwWe6kfWAWtaQwEJZZotB7P SQzwPH7YZQGE0QyI60Byzd9MYtHVl32rNWLPzgw1hmdlUCjqXcahAItf8H5vmHXuZn 0oUVpb//YflDigJnlyyawuV+fHG8Dzsy3kbo+40DwN5UHFdcKy9dq9Dx/Ma0L/EjzQ D7SgXEQIc14yh4BGdFA/XGwjlkBPCzlHs/fDgdKW/sEzW0QEFhmq3y8fUBOo+1vl/D 080drafinV9LQ== Original-Received: from alfajor (unknown [80.82.234.185]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 419CF1205A2; Tue, 21 Jun 2022 16:31:05 -0400 (EDT) In-Reply-To: <87v8syquog.fsf@gnu.org> (Tassilo Horn's message of "Sat, 18 Jun 2022 09:37:07 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291500 Archived-At: > Indeed, that looks at least surprising. When you do em-v the basic > completion style cannot do anything and so the partial-completion style > completes to emacs-v which is the common prefix of both emacs-version > and emacs-news-view-mode for this style. But when doing emacs-v > afterwards, the basic style can complete and only to emacs-version. Indeed, the way most/all `completion-try-completion` functions are designed such that the returned string results in the exact same set of matching candidates *when using the same style*. That can result in surprises when the returned string ends up suddenly having matching candidates in styles with higher-priority, which thus "capture" the completion. For `partial-completion`, it might be possible to work around this problem by making it try the higher-priority styles to detect such captures and "neuter" them by adding appropriate `*` e.g. completing `em-v` to `emacs*-v` instead of to `emacs-v`. Not sure how easy/ugly it would be, but it doesn't sound impossible (even more so if we limit ourselves to targetting the case of `basic` completion). > Maybe there should be a way to "lock in" a completion style, i.e., when > a more fuzzy style has computed completions in a previous step, it > should not fall back to a more strict one later in the process. Now of > course, there are more completion-styles than those in vanilla so the > level of fuzzyness is not known for all... That's another approach, indeed, tho "later in the process" is sadly ill-defined, so we'd have to find a heuristic which works well enough. Stefan