From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Wed, 09 Nov 2022 12:25:26 -0500 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87sfiyk3a2.fsf_-_@posteo.net> <838rkp4ptj.fsf@gnu.org> <87zgd58i7y.fsf@posteo.net> <83k0492u5i.fsf@gnu.org> <87fsew8g18.fsf@posteo.net> <83mt941cyd.fsf@gnu.org> <87fsewp0ec.fsf@posteo.net> <837d0814c9.fsf@gnu.org> <878rkooz1o.fsf@posteo.net> <831qqg1306.fsf@gnu.org> <874jvcowzm.fsf@posteo.net> <83y1soypvx.fsf@gnu.org> <87y1song5x.fsf@posteo.net> <83v8nsyof7.fsf@gnu.org> <87leoond7l.fsf@posteo.net> <87mt90tyns.fsf@thaodan.de> <87o7tgfw4m.fsf@posteo.net> <87eductx0x.fsf@thaodan.de> <871qqcfs9y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37055"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: =?windows-1252?Q?Bj=F6rn?= Bidar , Eli Zaretskii , rms@gnu.org, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 09 18:26:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osoqK-0009IF-JQ for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Nov 2022 18:26:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osopk-00075D-Mw; Wed, 09 Nov 2022 12:25:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osopg-00073u-SM for emacs-devel@gnu.org; Wed, 09 Nov 2022 12:25:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osopQ-0003Iz-G3; Wed, 09 Nov 2022 12:25:48 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A47BA10011A; Wed, 9 Nov 2022 12:25:28 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 122FE1000F3; Wed, 9 Nov 2022 12:25:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668014727; bh=PAO5NsrYqkhV/KKTN3+qZq/1E3cbrSbDndyhc7hDXBk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RCg97RarbWH2GvT1pYpIWSN4d0+eQcxcr7NFDy56WspdV2dfqbEquB2FgXJtSItZ+ ElvKH3L1gHihcrFDUPUeWl8hXx8uiIK8ALyMHuF+LuwHcRKFjKOa9EiHadHC9mAOQ5 VtxMw1gmjDj42TWEQ1vx9V8DRDzC3SYlqPLtSRD5+8ApUJinVEFIw3BaxtxIhmHUC8 l3ea3+5HrYxgj0bdKo0i0TyrVPhhU0dxri9cSB8tQYXvjqC8qBlL74rAwAnpBuW0/U qP3/Ix7edLMM3F6ga1H1L7muQ9QtxhviabzHxbf2txVX1buR2EvBJ/qYmj/whG7Ntf Qt6QyZjDUsy0w== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F14A01202A7; Wed, 9 Nov 2022 12:25:26 -0500 (EST) In-Reply-To: <871qqcfs9y.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 09 Nov 2022 08:26:01 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299415 Archived-At: >> Without such a system the package could be without use in many cases. > Many is probably the word of contention here. If you take a look at > elpa.git:elpa-packages, you'll find only a few :make or :shell-command > directives, none of which are critical. nongnu.git:elpa-packages has > non at all. Indeed. We don't use `make` or `ninja` to compile the ELisp files, instead we impose a standardized way to compile them. [ And those packages which rely on special build procedures will often suffer from problems with the native compiler, which will lazily recompile the files to native code without paying attention to the special build requirements. ] > One thing I worry about, but which has also been discussed > here are :renames. Indeed. Currently `elpa-admin.el` doesn't obey them when using "install from Git" (it does obey them when building the tarballs, of course) :-( > E.g. Vertico uses these to move extensions from a subdirectory to the > main directory for packaging. But moving the files would be > registered by the VCS, and could make committing changes more > difficult. Maybe we could create symbolic/hard links instead > of renaming? Moving is definitely out of the question, but symlinks and hardlinks are also problematic. We should probably document that `:renames` are not fully supported in all cases and should thus be avoided. I currently count 6 :renames, two for `extensions/` and 4 for `docs/`. AFAIK Those for docs are needed only because `package-install` handles `.info` files only in the root directory of packages, but that doesn't afflict `package-vc`, so we should be able to find a better solution. Those for `extensions/` can be handled by adding `extensions/` to the `load-path` in the `-autoloads.el` generated by `package-vc-install`. Stefan