From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter and major mode inheritance Date: Sat, 19 Nov 2022 10:19:46 -0500 Message-ID: References: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> <1B76E73A-0DCD-456E-9F28-0E90723DA66D@gmail.com> <83sfif8cl2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11493"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu , emacs-devel@gnu.org, theo@thornhill.no To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 16:20:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owPe3-0002lf-Oh for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 16:20:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owPdN-0000XS-BE; Sat, 19 Nov 2022 10:19:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owPdL-0000Ws-H3 for emacs-devel@gnu.org; Sat, 19 Nov 2022 10:19:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owPdJ-0001zq-KD; Sat, 19 Nov 2022 10:19:55 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1B20D1000F2; Sat, 19 Nov 2022 10:19:51 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A0939100099; Sat, 19 Nov 2022 10:19:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668871188; bh=tJAhU/vG4uB2CowmL1hOCGyWay6w/S8iHt/2JIfd2YM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=T8PAKAMdhJCl2VynCFcx+rupr92kA7f8GnUB7opounXAzrDWaCOG9vL6K3m8UsRbQ SpddO3HoqLqcvAVWM8urM54cPWIJsL0VBtdJTUBtWu38o8OGnl6/TsWRj8/+caFnF4 NminPhz3/ZCk+wliZO9Udf3hVS6dFmhbz0GtggOhcrlX7KCShZGrfJW+qYhamR2Tjy YQO98lJ1B0b9Sry8PvB31zjd5WVrG7dEHlUYuJ9X8uoVAHEHp/MPW0GgcZm9xjT/t/ O9WOU3LxfrO6bvNYJlrgnUg+j4zavJ9jTYSBkK5wwLNYyXc0WvRiuid4OvZK+N5b6l wV7XkdjvN3xyw== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 51B20120DBB; Sat, 19 Nov 2022 10:19:48 -0500 (EST) In-Reply-To: <83sfif8cl2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Nov 2022 12:26:17 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300182 Archived-At: >> Anyway, does anyone think this is a good/bad idea? Should I go implement >> this on css, js, c, etc? It can also be the other way around: instead of >> having c-mode being the virtual mode, we can leave c-mode as-is, and have >> a c-base-mode inherited by c-mode and c-ts-mode. And similarly >> rss-base-mode, rss-mode, and rss-ts-mode. > > I'd prefer leaving the original modes as-is. That should cause less > compatibility problems, I think. > > Stefan, any thoughts? To the extent that Emacs-29's new `major-mode-remap-alist` can be used to select which mode to use, we can indeed leave the original modes as-is. Another argument in favor is that it's a bit tricky to make `-mode` both the parent mode and the standard entry point: we do that for `tex-mode` but the implementation is ugly. [ If it weren't for this implementation problem, it would be my favorite choice. So maybe the better option is to add specific support for that in `define-derived-mode`, where we could implement it cleanly and thus also fix the ugly gymnastics of `tex-mode`. ] OTOH it's a bit jarring to have the generic term `-mode` refer to a specific implementation. For that reason, my preference is for: - `--mode` as the shared parent. - `-mode` as a dispatch function that calls the appropriate specific major mode which could be `-ts-mode`, or `cc--mode`, or `-with-JSX-mode`, or ... Stefan