From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Code navigation for sh-mode with Tree-sitter Date: Tue, 06 Dec 2022 18:50:01 -0500 Message-ID: References: <1B9F9B3A-A757-4A65-9653-CD0112EB8895@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , Yuan Fu , emacs-devel@gnu.org To: =?windows-1252?Q?Jo=E3o?= Paulo Labegalini de Carvalho Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 00:50:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2hiD-0004fb-81 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 00:50:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2hha-000493-C6; Tue, 06 Dec 2022 18:50:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2hhR-00048c-1x for emacs-devel@gnu.org; Tue, 06 Dec 2022 18:50:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2hhP-00027S-3a for emacs-devel@gnu.org; Tue, 06 Dec 2022 18:50:08 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A4D2100126; Tue, 6 Dec 2022 18:50:05 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9A26A1000FF; Tue, 6 Dec 2022 18:50:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670370602; bh=4C2o3OfKFJmwkzXSmUV4qGlu3FDoboi41G97AnKBS04=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pHKYZnL1ISCdAd3Ho1oPa35DmIb5qj0E5gNqx5ckYMVEiL1JtjfPg2w+dRS94qDXy Im34nG7R3uqpzyPhpPFj3goTs6tOcFcGES8ti2y9jbeJrRf+ppR/Ii6M8Lp9nTwfqS B1kuO7EirVAy6h8wvVjwihJaIjDSLyPI1D4CJ9H4XCOVAVmWwQj4ToIHKm27XV9xZT HcKc9eeQWZwoEMDdWlEzx2du23YTIV27AfZQrMS8OYyVfPqKWHtfnQj8SH+yPyhE3D YwQ/ysRMxUbSdAcH2+wlCW2s+n3P6BNNywWYF7D+Bc9mcRm2i3255ni0BOYLUKWb8p VhwS8KTE43iew== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 88DF71209C1; Tue, 6 Dec 2022 18:50:02 -0500 (EST) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o?= Paulo Labegalini de Carvalho"'s message of "Tue, 6 Dec 2022 16:43:39 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300993 Archived-At: > However, with negative arguments that does not happen, as > `sh-mode--treesit-beginning-of-defun' moves point to (beginning of) the > closest sibling function (after point) and > `sh-mode--treesit-end-of-defun' moves > point to (end of) the closest sibling function (before point). In this > case, the selected functions to which point move to are not the same. Please read the docstring of `end-of-defun-function`, because I suspect that you are confused about what it's supposed to do. E.g. it's not supposed to "move point to (end of) the closest sibling function", so I think you'll need to set it to a different function than `sh-mode--treesit-end-of-defun`. > A second look revealed that the function set to `end-of-defun-function' is > called without arguments, As documented in its docstring, yes. > thus when used can only produce motions that are symmetric to > `beginning-of-defun-function'. Not sure what you mean by that. Stefan