From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 4302bc9b0f1: Allow --debug-init to debug all errors in init files Date: Sun, 25 Jun 2023 19:26:27 -0400 Message-ID: References: <168735410313.21082.15347717294570895563@vcs2.savannah.gnu.org> <20230621132823.6C945C06C79@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23108"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 26 01:27:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDZ8r-0005n7-DH for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Jun 2023 01:27:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDZ7z-0001KO-C5; Sun, 25 Jun 2023 19:26:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDZ7u-0001Jo-SB for emacs-devel@gnu.org; Sun, 25 Jun 2023 19:26:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDZ7s-0002ly-Po; Sun, 25 Jun 2023 19:26:38 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E9718441774; Sun, 25 Jun 2023 19:26:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 83EEF4416FD; Sun, 25 Jun 2023 19:26:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687735589; bh=rW4WBVBeTXJmz7rzRz01G3Ck1LsH6sH+bZeT2wml/wE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MPXKObzrCm9FtEsrNwtoRA7vy3jckAFzEPkLQo6Veqjgbyp69GYUmMVeiJ1azmZYc vlk5Np4sTUzdNTU3/Qb294LXPpZunUGasaFd0kvE2Vk3HJ6gcxp6IYlOCzVX6c4Jea 0lEsa098BjE6JSHOdw0JCQxJ+MYG8haf/NtQ/V6K3qJ7Puu14jiyLpAhLqSi26tDaY AzA7FpEWtZi+eRxTL6XWNPpICE9NHjDkEcNcFVtgKNfr0e/tzHX4ibME7C3WEVLVdB iGqjJ0hufZGIKdOtiffTzf5xvpKSvvRhLdUtKzh5wz1c9+H46+6Yh4DcP3Y9bamsjb 19rwQTPgBLcDw== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6235B120513; Sun, 25 Jun 2023 19:26:29 -0400 (EDT) In-Reply-To: <20230621132823.6C945C06C79@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Wed, 21 Jun 2023 09:28:23 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307217 Archived-At: Hi Eli, > Allow --debug-init to debug all errors in init files > > * lisp/startup.el (startup--load-user-init-file): Ignore the value > of 'debug-ignored-errors' when loading init files if we were > invoked interactively with --debug-init. (Bug#64163) I understand you didn't like my patch because of the cosmetic renaming it included, but you threw away some of the baby with the bathwater: > - (load (if (equal (file-name-extension init-file-name) > - "el") > - (file-name-sans-extension init-file-name) > - init-file-name) > - 'noerror 'nomessage)) > + ;; If they specified --debug-init, enter the debugger > + ;; on any error whatsoever. > + (let ((debug-ignored-errors > + (if (and init-file-debug (not noninteractive)) > + nil > + debug-ignored-errors))) > + (load (if (equal (file-name-extension init-file-name) > + "el") > + (file-name-sans-extension init-file-name) > + init-file-name) > + 'noerror 'nomessage))) Now the changes I make to `debug-ignored-errors` in my `init.el` are thrown away :-( Stefan