From: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: monnier+gnu/emacs@rum.cs.yale.edu, monnier+gnu/emacs@cs.yale.edu,
emacs-devel@gnu.org
Subject: Re: popup menu support for smerge-mode
Date: 20 Oct 2003 17:23:19 -0400 [thread overview]
Message-ID: <jwv8ynfliun.fsf-monnier+emacs/devel@vor.iro.umontreal.ca> (raw)
In-Reply-To: <20030926.165808.260114910.jet@gyve.org>
> mine and other uses special menus. I added "Keep alternative" to the
> menus. Other including whole uses the smerge menu appeared on the
> menu bar.
Don't forget that conflicts can have a 3-parts shape where there's not just
"mine" and "other" but also the ancestor, in which case there's no single
"Keep alternative".
> +(easy-menu-define smerge-mode-mine-popup-menu nil
> + "Popup menu for mine area in `smerge-mode'."
> + '(nil
> + ["Keep This" smerge-keep-current :help "Use current (at point) version"]
> + ;; mine <-> other
> + ["Keep Alternative" smerge-keep-other :help "Use alternative version"]
> + ["Keep All" smerge-keep-all :help "Keep all three versions"]
> + "---"
> + ["More..." (popup-menu smerge-mode-menu) :help "Show full SMerge mode menu"]
> + ))
> +(easy-menu-define smerge-mode-other-popup-menu nil
> + "Popup menu for other area in `smerge-mode'."
> + '(nil
> + ["Keep This" smerge-keep-current :help "Use current (at point) version"]
> + ;; other <-> mine
> + ["Keep Alternative" smerge-keep-mine :help "Use alternative version"]
> + ["Keep All" smerge-keep-all :help "Keep all three versions"]
> + "---"
> + ["More..." (popup-menu smerge-mode-menu) :help "Show full SMerge mode menu"]
> + ))
I'd rather introduce a new function smerge-keep-alternative which
will determine whether to use `other' or `mine' depending on `current'.
This way there's only one menu rather than two with the same appearance
but different behavior.
> + (when (and b e (not (= b e)))
I think this can be simplified to `unless (eq e b)' because `e' and `b'
are either both locations or both nil.
> + ;; Delete overlays
> + (when (or
> + (not (overlay-buffer o-whole)) ;; dead
> + (< (- (overlay-end o-whole) (overlay-start o-whole))
> + region-whole)) ;; shrinked up
> + (mapc 'delete-overlay (cons o-whole os-sub)))))))
I agree it's easier to remove the overlays from smerge-activate-popup-menu,
but that means they'll just never be removed if the user doesn't use
this new feature. I think it really needs to be done somewhere else
instead (E.g. at the same place as the auto-leave code is run. We'll
probably need to introduce a new function `smerge-post-resolution-update'
which will do the auto-leave check and will remove the overlays).
Stefan
next prev parent reply other threads:[~2003-10-20 21:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 12:16 popup menu support for smerge-mode Masatake YAMATO
2003-01-11 19:41 ` Stefan Monnier
2003-08-24 6:03 ` Masatake YAMATO
2003-08-24 14:42 ` Stefan Monnier
2003-09-18 8:54 ` Masatake YAMATO
2003-09-18 15:27 ` Stefan Monnier
2003-09-19 9:25 ` Masatake YAMATO
2003-09-19 15:57 ` Stefan Monnier
2003-09-26 7:58 ` Masatake YAMATO
2003-09-26 8:44 ` Miles Bader
2003-09-26 8:53 ` Behavior of evaporate Masatake YAMATO
2003-09-26 9:05 ` Miles Bader
2003-09-26 9:17 ` David Kastrup
2003-09-26 15:59 ` Stefan Monnier
2003-09-27 2:31 ` Richard Stallman
2003-09-30 20:56 ` Alex Schroeder
2003-10-20 21:23 ` Stefan Monnier [this message]
2004-03-10 4:32 ` popup menu support for smerge-mode Masatake YAMATO
2004-03-11 7:00 ` Masatake YAMATO
2003-10-14 3:59 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8ynfliun.fsf-monnier+emacs/devel@vor.iro.umontreal.ca \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=monnier+gnu/emacs@cs.yale.edu \
--cc=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).