From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Suggestion for autorevert.el Date: 02 Apr 2004 00:02:34 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <87zna6l1kn.fsf@offby1.atm01.sea.blarg.net> <200404010330.i313Ug621242@raven.dms.auburn.edu> <200404020409.i3249Vw24362@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1080882391 12562 80.91.224.253 (2 Apr 2004 05:06:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Apr 2004 05:06:31 +0000 (UTC) Cc: offby1@blarg.net, rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Apr 02 07:06:22 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B9Gso-0000UO-00 for ; Fri, 02 Apr 2004 07:06:22 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B9Gso-0001jQ-00 for ; Fri, 02 Apr 2004 07:06:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9Gpr-0002e2-3n for emacs-devel@quimby.gnus.org; Fri, 02 Apr 2004 00:03:19 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B9Gpj-0002ax-PQ for emacs-devel@gnu.org; Fri, 02 Apr 2004 00:03:11 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B9GpD-000243-Bd for emacs-devel@gnu.org; Fri, 02 Apr 2004 00:03:10 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9GpC-00020i-MI; Fri, 02 Apr 2004 00:02:38 -0500 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 6E6C321277; Fri, 2 Apr 2004 00:02:35 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 047778B4C3; Fri, 2 Apr 2004 00:02:34 -0500 (EST) Original-To: Luc Teirlinck In-Reply-To: <200404020409.i3249Vw24362@raven.dms.auburn.edu> Original-Lines: 14 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.9, requis 5, BAYES_00 -4.90) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21186 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21186 > The added code, which calls the non-primitive and non-optimized > `get-buffer-window-list' and does some consing, only gets called when > one needs to revert a _file buffer_. In my usage, this happens very > infrequently. If a huge amount of files are continuously reverting, > then maybe there could be a problem. I think all the existing code that has to deal with similar issues just uses get-buffer-window and ignores the problem of the buffer being displayed in several windows. So I'm pleasantly impressed by your patch, and at the same time, I'm wondering whether it's worth the trouble. Stefan