From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: FW: fit-frame.el Date: Mon, 10 Mar 2008 11:34:56 -0400 Message-ID: References: <004301c88269$637220e0$0600a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205163328 28685 80.91.229.12 (10 Mar 2008 15:35:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Mar 2008 15:35:28 +0000 (UTC) Cc: Emacs-Devel To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 10 16:35:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JYk2N-0007K1-Sb for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2008 16:35:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYk1p-00085L-HW for ged-emacs-devel@m.gmane.org; Mon, 10 Mar 2008 11:35:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JYk1l-00084B-Ga for emacs-devel@gnu.org; Mon, 10 Mar 2008 11:35:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JYk1j-00082f-U5 for emacs-devel@gnu.org; Mon, 10 Mar 2008 11:35:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYk1j-00082c-P1 for emacs-devel@gnu.org; Mon, 10 Mar 2008 11:34:59 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JYk1j-0007Bn-ML for emacs-devel@gnu.org; Mon, 10 Mar 2008 11:34:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmgCAFfy1EfO+J2CdGdsb2JhbACQfgEwmCuBBw X-IronPort-AV: E=Sophos;i="4.25,474,1199682000"; d="scan'208";a="15793117" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 10 Mar 2008 11:34:56 -0400 Original-Received: from pastel.home ([206.248.157.130]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id QSS45256; Mon, 10 Mar 2008 11:34:56 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5BE8D805A; Mon, 10 Mar 2008 11:34:56 -0400 (EDT) In-Reply-To: <004301c88269$637220e0$0600a8c0@us.oracle.com> (Drew Adams's message of "Sun, 9 Mar 2008 20:44:12 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92041 Archived-At: > Resending for review. Could you describe what is the behavior of your function when there are more than 1 windows in the frame? After trying it out, I'm still not sure. I get the impression that part of the problem is that you calculate a frame size that would allow all windows to have the right size, but you don't actually resize the windows, so they get a somewhat arbitrary size which may or may not be the right one. Also when the C-u arg is provided, it seems to resize the frame to the size it should have if it displayed only 1 window, whereas of course it's not the case: there are other windows there (otherwise C-u makes no difference anyway). So again, the result is somewhat unexpected. I'd have expected it to resize the frame so that the window fits the buffer, and so that the other windows stay "unchanged". Stefan