From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-directory breakage Date: Mon, 05 May 2008 21:03:10 -0400 Message-ID: References: <20080505152149.E5BB99F054B@snark.thyrsus.com> <857ie8ahr3.fsf@lola.goethe.zz> <20080506000456.GA14206@thyrsus.com> <200805060036.m460aVto021222@sallyv1.ics.uci.edu> <20080506004849.GA14523@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210035862 20974 80.91.229.12 (6 May 2008 01:04:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 01:04:22 +0000 (UTC) Cc: "Eric S. Raymond" , Dan Nicolaescu , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 03:04:56 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtBc0-0008Hh-54 for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 03:04:56 +0200 Original-Received: from localhost ([127.0.0.1]:45279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBbI-00059M-Ey for ged-emacs-devel@m.gmane.org; Mon, 05 May 2008 21:04:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtBaM-0004qM-1R for emacs-devel@gnu.org; Mon, 05 May 2008 21:03:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtBaK-0004pO-6O for emacs-devel@gnu.org; Mon, 05 May 2008 21:03:13 -0400 Original-Received: from [199.232.76.173] (port=55745 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBaJ-0004pI-RF for emacs-devel@gnu.org; Mon, 05 May 2008 21:03:11 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtBaJ-0001dz-QZ for emacs-devel@gnu.org; Mon, 05 May 2008 21:03:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAOZKH0hMCqqd/2dsb2JhbACBU6or X-IronPort-AV: E=Sophos;i="4.27,440,1204520400"; d="scan'208";a="19956229" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 05 May 2008 21:03:11 -0400 Original-Received: from pastel.home ([76.10.170.157]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id MGJ03911; Mon, 05 May 2008 21:03:11 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A617C7FFC; Mon, 5 May 2008 21:03:10 -0400 (EDT) In-Reply-To: <20080506004849.GA14523@thyrsus.com> (Eric S. Raymond's message of "Mon, 5 May 2008 20:48:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96557 Archived-At: >> Also please put the backend in a buffer-local variable in the vc-dir >> buffer, that way all the vc-responsible-backend calls in vc-generic-* can be >> eliminated. >> With that change this code will work. >> It does not work right now for at least hg, git and svn. > The recommended change may be a good idea, but I'm not sure. Those backend > checks are now being done at file granularity because some people were vocal > about support for mixing multiple VCSes in a directory. I believe you have misunderstood the request, then: "support the multi-VCS case" means exactly what Dan asks, which is "make sure only one backend is used for a given command, even if the command includes files that are under various backends". I.e. the issue is not "several subdirs of *vc-dir* which each use a different backend", but "all the files under *vc-dir* are under the control of several backends at the same time". Stefan