From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: M-! M-n should fetch filename (Re: FFAP) Date: Tue, 10 Nov 2009 12:29:36 -0500 Message-ID: References: <3b31caf90911051613w80af4cu61352a29ce5dcd77@mail.gmail.com> <87vdhoe73d.fsf@mail.jurta.org> <87y6mkb6qr.fsf@mail.jurta.org> <87bpjfiark.fsf@mail.jurta.org> <87bpjcq9z2.fsf_-_@mail.jurta.org> <874op3jigp.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257874197 8414 80.91.229.12 (10 Nov 2009 17:29:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Nov 2009 17:29:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 10 18:29:50 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N7uXM-0003N0-TM for ged-emacs-devel@m.gmane.org; Tue, 10 Nov 2009 18:29:49 +0100 Original-Received: from localhost ([127.0.0.1]:43819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7uXM-00028N-A4 for ged-emacs-devel@m.gmane.org; Tue, 10 Nov 2009 12:29:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7uXG-00025t-Ou for emacs-devel@gnu.org; Tue, 10 Nov 2009 12:29:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7uXC-00021A-6n for emacs-devel@gnu.org; Tue, 10 Nov 2009 12:29:42 -0500 Original-Received: from [199.232.76.173] (port=59694 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7uXB-00020x-SZ for emacs-devel@gnu.org; Tue, 10 Nov 2009 12:29:37 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33125) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7uXB-0007JY-J5 for emacs-devel@gnu.org; Tue, 10 Nov 2009 12:29:37 -0500 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nAAHTaLR023280; Tue, 10 Nov 2009 12:29:36 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 441B33A1DA; Tue, 10 Nov 2009 12:29:36 -0500 (EST) In-Reply-To: <874op3jigp.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 10 Nov 2009 02:59:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3403=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116806 Archived-At: > *************** > *** 2136,2143 **** > (interactive > (list > (read-shell-command "Shell command: " nil nil > ! (and buffer-file-name > ! (file-relative-name buffer-file-name))) > current-prefix-arg > shell-command-default-error-buffer)) > ;; Look for a handler in case default-directory is a remote file name. > --- 2152,2163 ---- > (interactive > (list > (read-shell-command "Shell command: " nil nil > ! (let ((filename > ! (cond > ! ((eq major-mode 'dired-mode) > ! (dired-get-filename nil t)) > ! (buffer-file-name)))) > ! (and filename (file-relative-name filename)))) > current-prefix-arg > shell-command-default-error-buffer)) > ;; Look for a handler in case default-directory is a remote file name. I think if you rewrite it to (let ((filename (cond (buffer-file-name) ((eq major-mode 'dired-mode) (dired-get-filename nil t))))) (and filename (file-relative-name filename)))) it's a lot more clear why it's useful (it adds data, rather than just changing one data for another). Stefan