From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] some misuse of GCPROs Date: Sat, 19 Nov 2011 23:35:23 -0500 Message-ID: References: <4EC6667E.3040008@yandex.ru> <4EC694DD.4050908@yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321763746 8040 80.91.229.12 (20 Nov 2011 04:35:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Nov 2011 04:35:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 20 05:35:38 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRz7w-00048A-O2 for ged-emacs-devel@m.gmane.org; Sun, 20 Nov 2011 05:35:36 +0100 Original-Received: from localhost ([::1]:53167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRz7w-0006Ui-7b for ged-emacs-devel@m.gmane.org; Sat, 19 Nov 2011 23:35:36 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:54156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRz7q-0006Uc-1p for emacs-devel@gnu.org; Sat, 19 Nov 2011 23:35:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRz7l-00066U-QZ for emacs-devel@gnu.org; Sat, 19 Nov 2011 23:35:30 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRz7l-00066M-Mc for emacs-devel@gnu.org; Sat, 19 Nov 2011 23:35:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkIFAGyCyE5FpZyx/2dsb2JhbABDqBSCKYEGgXIBAQQBViMQCzQSFBgNJIgWtSKKFwSIGpl6hEs X-IronPort-AV: E=Sophos;i="4.69,541,1315195200"; d="scan'208";a="148661338" Original-Received: from 69-165-156-177.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.177]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Nov 2011 23:35:24 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D660559372; Sat, 19 Nov 2011 23:35:23 -0500 (EST) In-Reply-To: <4EC694DD.4050908@yandex.ru> (Dmitry Antipov's message of "Fri, 18 Nov 2011 21:24:45 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146098 Archived-At: >> I really dislike this inner_gcpro business, so I haven't installed >> this hunk. What is it needed for? > I too, but this is a fix for 'reuse GCPRO' error. The following code Oh, I see, thanks. I added the patch below, then. Stefan === modified file 'src/fileio.c' --- src/fileio.c 2011-11-20 02:29:42 +0000 +++ src/fileio.c 2011-11-20 04:31:52 +0000 @@ -3686,6 +3686,7 @@ int this_count = SPECPDL_INDEX (); int multibyte = ! NILP (BVAR (current_buffer, enable_multibyte_characters)); Lisp_Object conversion_buffer; + struct gcpro gcpro1; conversion_buffer = code_conversion_save (1, multibyte);