From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 3/9] Implement cygw32 Date: Tue, 07 Aug 2012 11:40:36 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344354052 22318 80.91.229.3 (7 Aug 2012 15:40:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 15:40:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 17:40:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Syltn-0006O0-Jq for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 17:40:47 +0200 Original-Received: from localhost ([::1]:44232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syltm-0000tt-Pf for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 11:40:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syltg-0000tH-Nb for emacs-devel@gnu.org; Tue, 07 Aug 2012 11:40:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Syltf-0008Dw-EB for emacs-devel@gnu.org; Tue, 07 Aug 2012 11:40:40 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:51407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syltf-0008Dr-90 for emacs-devel@gnu.org; Tue, 07 Aug 2012 11:40:39 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q77Fea7W029954; Tue, 7 Aug 2012 11:40:36 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 4FC16B4081; Tue, 7 Aug 2012 11:40:36 -0400 (EDT) In-Reply-To: (Daniel Colascione's message of "Tue, 07 Aug 2012 01:19:27 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4303=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4303> : streams <795854> : uri <1186120> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152254 Archived-At: > + AC_MSG_ERROR([Using win32 with an autotools build is only supported for Cygwin.]) Try to stick to "w32" and especially avoid "win32" since we don't like to make it sound like this is a win. BTW, the next step is probably to support a w32 GUI under GNU+Wine ;-) > --- a/lisp/international/mule-cmds.el > +++ b/lisp/international/mule-cmds.el > @@ -2670,7 +2670,8 @@ See also `locale-charset-language-names', `locale-language-names', > ;; On Windows, override locale-coding-system, > ;; default-file-name-coding-system, keyboard-coding-system, > ;; terminal-coding-system with system codepage. > - (when (boundp 'w32-ansi-code-page) > + (when (and (eq system-type 'windows-nt) > + (boundp 'w32-ansi-code-page)) > (let ((code-page-coding (intern (format "cp%d" w32-ansi-code-page)))) > (when (coding-system-p code-page-coding) > (unless frame (setq locale-coding-system code-page-coding)) Does w32-ansi-code-page ever make sense under Cygwin? If it can be useful for Cygwin, is it only useful in combination with the w32 GUI, or can it also be useful for Cygwin+X11? Wouldn't it be more correct to change w32fns.c so it does not define w32-ansi-code-page when built for Cygwin? Or on the contrary to move the definition of w32-ansi-code-page so it always gets defined under Windows, whether we build for Cygwin or not? > +(unless (eq system-type 'cygwin) > + (defcustom w32-allow-system-shell nil > + "Disable startup warning when using \"system\" shells." > + :type 'boolean > + :group 'w32)) > + > +(unless (eq system-type 'cygwin) > + (defcustom w32-system-shells '("cmd" "cmd.exe" "command" "command.com" > + "4nt" "4nt.exe" "4dos" "4dos.exe" > + "tcc" "tcc.exe" "ndos" "ndos.exe") > + "List of strings recognized as Windows system shells." > + :type '(repeat string) > + :group 'w32)) You can use a single `unless' around the two defcustoms. Hopefully someone else can review the core of your code. I'm familiar with none of those Windows thingies. I do like the feature, tho, Stefan