From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: The emacs_backtrace "feature" Date: Sat, 29 Sep 2012 21:48:39 -0400 Message-ID: References: <83lig3yaci.fsf@gnu.org> <505CC1FA.4070300@cs.ucla.edu> <874nmglvp4.fsf@mail.jurta.org> <83zk48egzb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348969727 31112 80.91.229.3 (30 Sep 2012 01:48:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2012 01:48:47 +0000 (UTC) Cc: Juri Linkov , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 30 03:48:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TI8eI-0005oR-52 for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2012 03:48:50 +0200 Original-Received: from localhost ([::1]:38412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TI8eC-0002p7-KC for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2012 21:48:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TI8eA-0002p0-U3 for emacs-devel@gnu.org; Sat, 29 Sep 2012 21:48:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TI8eA-0000Dy-4g for emacs-devel@gnu.org; Sat, 29 Sep 2012 21:48:42 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TI8e8-0000DQ-G4; Sat, 29 Sep 2012 21:48:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLT4/2dsb2JhbABEtBGBCIIVAQEEAVYjEAs0EhQYDSSIHAW6CZBEA545hHqBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200291119" Original-Received: from 69-196-180-248.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.248]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Sep 2012 21:48:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 66B04594BF; Sat, 29 Sep 2012 21:48:39 -0400 (EDT) In-Reply-To: <83zk48egzb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Sep 2012 22:01:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153727 Archived-At: >> Would be better to increase the number of lines to 24 or 32 >> or any other round number. > Instead of guessing, I'd suggest a small research: collect all the > backtraces reported to the bug tracker, and build the historgram of > their sizes. Then decide based on that. > I would also suggest some heuristics, e.g. if the crash is in GC, the > number will have to be much larger. I really dislike the idea of writing those backtraces into a file (when RMS mentioned it, I was shocked), but the more it goes, the more I think it would make sense for the non-ENABLE_CHECKING builds. Tho maybe just not showing the backtraces at all would work just as well in those cases. I still would prefer going back to having the easserts in macros rather than in functions (so that the assertion itself immediately gives you the line-number, without having to go through the addr2line rigmarole). Stefan