From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables.
Date: Thu, 15 Aug 2013 16:32:03 -0400
Message-ID: <jwv8v02ae88.fsf-monnier+emacs@gnu.org>
References: <E1VA0wJ-0001uE-N7@vcs.savannah.gnu.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1376598741 12845 80.91.229.3 (15 Aug 2013 20:32:21 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 15 Aug 2013 20:32:21 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Michael Albinus <michael.albinus@gmx.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 15 22:32:23 2013
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VA4DW-0002BT-R6
	for ged-emacs-devel@m.gmane.org; Thu, 15 Aug 2013 22:32:22 +0200
Original-Received: from localhost ([::1]:55307 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VA4DW-0000gJ-Fc
	for ged-emacs-devel@m.gmane.org; Thu, 15 Aug 2013 16:32:22 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <monnier@iro.umontreal.ca>) id 1VA4DK-0000eE-Ni
	for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:32:20 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <monnier@iro.umontreal.ca>) id 1VA4DC-0008Aa-Bh
	for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:32:10 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <monnier@iro.umontreal.ca>) id 1VA4DC-0008AV-8u
	for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:32:02 -0400
Original-Received: from [98.143.210.201] (port=50668 helo=ceviche.home)
	by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <monnier@iro.umontreal.ca>)
	id 1VA4DB-0006jK-Vl; Thu, 15 Aug 2013 16:32:02 -0400
Original-Received: by ceviche.home (Postfix, from userid 20848)
	id 2346C660F8; Thu, 15 Aug 2013 16:32:03 -0400 (EDT)
In-Reply-To: <E1VA0wJ-0001uE-N7@vcs.savannah.gnu.org> (Michael Albinus's
	message of "Thu, 15 Aug 2013 17:02:23 +0000")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:162788
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/162788>

> +  (defvar buffer-name)

This is bad: buffer-name should not be a dynamically-scoped variable.


        Stefan