From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Set operations on bool-vectors Date: Fri, 20 Sep 2013 21:57:04 -0400 Message-ID: References: <523CD363.6020400@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379728641 10794 80.91.229.3 (21 Sep 2013 01:57:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Sep 2013 01:57:21 +0000 (UTC) Cc: Emacs development discussions To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 21 03:57:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VNCRm-00070F-Pi for ged-emacs-devel@m.gmane.org; Sat, 21 Sep 2013 03:57:22 +0200 Original-Received: from localhost ([::1]:58346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNCRm-0007WM-Cc for ged-emacs-devel@m.gmane.org; Fri, 20 Sep 2013 21:57:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNCRd-0007Vl-68 for emacs-devel@gnu.org; Fri, 20 Sep 2013 21:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VNCRV-0001Tw-SP for emacs-devel@gnu.org; Fri, 20 Sep 2013 21:57:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNCRV-0001Tn-NU for emacs-devel@gnu.org; Fri, 20 Sep 2013 21:57:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxIvz/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFFxIvz/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28533026" Original-Received: from 69-196-139-243.dsl.teksavvy.com (HELO pastel.home) ([69.196.139.243]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Sep 2013 21:53:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 398EF66A4A; Fri, 20 Sep 2013 21:57:04 -0400 (EDT) In-Reply-To: <523CD363.6020400@dancol.org> (Daniel Colascione's message of "Fri, 20 Sep 2013 15:59:47 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163523 Archived-At: > I've implemented built-in set operations on bool vectors. Thanks. Looks good. > According to my benchmarks, these operations are about 1,000 times > faster than the compiled elisp equivalents. I'd expect no less. > === modified file 'src/alloc.c' > --- src/alloc.c 2013-09-04 22:34:04 +0000 > +++ src/alloc.c 2013-09-19 22:24:27 +0000 > @@ -2003,6 +2003,29 @@ > return val; > } Could you describe the intention of the changes in alloc.c (basically, provide ChangeLog entries)? > + doc: /* Compute A = B ^ C, bitwise exclusive or. Why not make it C = A ^ B and then make C optional? Same for other similar functions: make the destination argument optional. Stefan