From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Removing rollback from VC mode - request for comment Date: Thu, 11 Dec 2014 10:47:24 -0500 Message-ID: References: <20141211092138.6D5F6C008E@snark.thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418316561 24913 80.91.229.3 (11 Dec 2014 16:49:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Dec 2014 16:49:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@snark.thyrsus.com (Eric S. Raymond) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 11 17:49:17 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xz6vU-00019p-Mp for ged-emacs-devel@m.gmane.org; Thu, 11 Dec 2014 17:49:16 +0100 Original-Received: from localhost ([::1]:52441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz6vU-0004EM-BM for ged-emacs-devel@m.gmane.org; Thu, 11 Dec 2014 11:49:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz6lc-0007hC-UE for emacs-devel@gnu.org; Thu, 11 Dec 2014 11:39:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz6lU-0000MU-GQ for emacs-devel@gnu.org; Thu, 11 Dec 2014 11:39:04 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz6lU-0000MK-Ch for emacs-devel@gnu.org; Thu, 11 Dec 2014 11:38:56 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjsPAOwQflRFxIoH/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCws0EhQYDYhuCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IPAS-Result: AjsPAOwQflRFxIoH/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCws0EhQYDYhuCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="100202320" Original-Received: from 69-196-138-7.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.7]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2014 11:38:55 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id BC00EAF0; Thu, 11 Dec 2014 10:47:24 -0500 (EST) In-Reply-To: <20141211092138.6D5F6C008E@snark.thyrsus.com> (Eric S. Raymond's message of "Thu, 11 Dec 2014 04:21:38 -0500 (EST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179793 Archived-At: > Rollback is a case in point. It is a command that lets you undo the > last checkin. Only SCCS and RCS actually support it. Git possibly > could, in theory, but the Git implementation would be tricky and have > sharp edges when the last revision had been pushed. Actually, I think most VCS can support it one way or another. > might be using it on some remnant RCS repo (I think we can safely > consider SCCS dead to us at this point). And the broader question is We've had some bug reports about vc-sccs.el in the not-completely-distant past, so there might still be such people out there. But contrary to what the above two statements might lead you to think, I'm in favor of removing this rollback, because I don't think it's good enough as it stands. E.g. I think it should be replaced by an `uncommit' which would be the opposite of `commit' and should ideally preserve as much info as possible (e.g. not change the file's contents, and stash the commit message somewhere so it can be re-used if you decide to recommit). Stefan