From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options.
Date: Sun, 14 Dec 2014 18:36:18 -0500 [thread overview]
Message-ID: <jwv8ui9yfg6.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <877fxuxioc.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 14 Dec 2014 12:09:07 -0500")
> FWIW, I think your version does not explain what the change provides,
> only that it was made (it basically restates the diff). I don't know if
> that's what you intended.
The standard ChangeLog format is meant indeed to describe what the diff
is intended to change in the code. The explanation of why we might want
this change can be placed in the code (best choice when possible), or
otherwise it can be placed just before the ChangeLog-formatted text
(e.g. in the Summary line or right below it).
Stefan
next prev parent reply other threads:[~2014-12-14 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141214114850.13638.56381@vcs.savannah.gnu.org>
[not found] ` <E1Y07fP-0003ZA-N8@vcs.savannah.gnu.org>
2014-12-14 14:36 ` [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options Stefan Monnier
2014-12-14 17:09 ` Ted Zlatanov
2014-12-14 23:36 ` Stefan Monnier [this message]
2014-12-15 1:07 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8ui9yfg6.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).