* Re: [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks
[not found] ` <20160921150102.AA77722016F@vcs.savannah.gnu.org>
@ 2016-09-21 15:10 ` Stefan Monnier
2016-09-21 16:02 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2016-09-21 15:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> + (old-track-mouse track-mouse))
[...]
> + t (lambda () (setq track-mouse old-track-mouse)))))))
To allow two packages to set track-mouse without one setting being
(temporally) nested within the other, we could do
(push 'mouse-drag track-mouse)
[...]
(setq track-mouse (delq 'mouse-drag track-mouse))
-- Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks
2016-09-21 15:10 ` [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks Stefan Monnier
@ 2016-09-21 16:02 ` Eli Zaretskii
2016-09-21 16:28 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2016-09-21 16:02 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 21 Sep 2016 11:10:34 -0400
>
> > + (old-track-mouse track-mouse))
> [...]
> > + t (lambda () (setq track-mouse old-track-mouse)))))))
>
> To allow two packages to set track-mouse without one setting being
> (temporally) nested within the other, we could do
>
> (push 'mouse-drag track-mouse)
> [...]
> (setq track-mouse (delq 'mouse-drag track-mouse))
But that wasn't the purpose of the fix. What you suggest fixes a
different problem, one that has yet to be reported; the original code
which simply gave track-mouse the nil value had the same problem.
Right?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks
2016-09-21 16:02 ` Eli Zaretskii
@ 2016-09-21 16:28 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2016-09-21 16:28 UTC (permalink / raw)
To: emacs-devel
>> (push 'mouse-drag track-mouse)
>> [...]
>> (setq track-mouse (delq 'mouse-drag track-mouse))
> But that wasn't the purpose of the fix. What you suggest fixes a
> different problem, one that has yet to be reported;
Right, it would fix another problem additionally to fixing the problem
that your patch fixed.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-21 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160921150102.25705.25564@vcs.savannah.gnu.org>
[not found] ` <20160921150102.AA77722016F@vcs.savannah.gnu.org>
2016-09-21 15:10 ` [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks Stefan Monnier
2016-09-21 16:02 ` Eli Zaretskii
2016-09-21 16:28 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).