From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Some testing issues Date: Sat, 08 Jul 2017 00:45:10 -0400 Message-ID: References: <8737a8j61r.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499489169 1174 195.159.176.226 (8 Jul 2017 04:46:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 04:46:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 08 06:45:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dThcy-0007xW-1H for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 06:45:56 +0200 Original-Received: from localhost ([::1]:59831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dThd0-0006ET-54 for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 00:45:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dThcU-0006EB-N7 for emacs-devel@gnu.org; Sat, 08 Jul 2017 00:45:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dThcQ-0007S7-Rc for emacs-devel@gnu.org; Sat, 08 Jul 2017 00:45:26 -0400 Original-Received: from [195.159.176.226] (port=51263 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dThcQ-0007Rd-Kz for emacs-devel@gnu.org; Sat, 08 Jul 2017 00:45:22 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dThcE-0005x0-WF for emacs-devel@gnu.org; Sat, 08 Jul 2017 06:45:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ziiJajjxDDhk7SuNzlDE3gjlm9Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216301 Archived-At: > Several of the tests call the function todo-toggle-view-done-items, > which contains this code: > > (if (not (pos-visible-in-window-p shown)) > (recenter) This code is indeed brittle: pos-visible-in-window-p presumes that (current-buffer) is the same as (window-buffer (selected-window)), but that's not always the case. Stefan