From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Mon, 04 Dec 2017 12:52:39 -0500 Message-ID: References: <20171129233237.27462.23351@vcs0.savannah.gnu.org> <20171130214621.GA22157@ACM> <27985594-3bb4-ce88-8928-2ccfeac13eae@yandex.ru> <20171201154913.GB3840@ACM> <1e542021-e389-cca4-6acd-349efddb2652@yandex.ru> <20171201223529.GG3840@ACM> <4a94ec5c-efdd-50f1-ff4d-277f5f45c2df@yandex.ru> <83lgil1qme.fsf@gnu.org> <83d13x1j2s.fsf@gnu.org> <34abea95-c7f7-e8fa-8407-8c2fd2a4cfe1@yandex.ru> <83y3mkzw1n.fsf@gnu.org> <83mv2zzv7z.fsf@gnu.org> <83o9nexy48.fsf@gnu.org> <83d13uxug5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512410058 17622 195.159.176.226 (4 Dec 2017 17:54:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 17:54:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 04 18:54:14 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLuwW-00048s-4C for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 18:54:12 +0100 Original-Received: from localhost ([::1]:44524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLuwa-0006xE-D0 for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 12:54:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLuvH-0006Bf-9O for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:52:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLuvD-0003Fo-BV for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:52:55 -0500 Original-Received: from [195.159.176.226] (port=60305 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLuvD-0003Eq-4T for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:52:51 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eLuv2-0008C1-Ku for emacs-devel@gnu.org; Mon, 04 Dec 2017 18:52:40 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ZeQ31WQAmihTWPlE63mLDkE4g4A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220716 Archived-At: >> > The code which supports PREV-CHUNK is already in Emacs, so the >> > question IMO is "why remove it"? >> ?Which code is that? > prog-indentation-context and its support in prog-widen. AFAICT prog-widen doesn't look at the PREVIOUS-CHUNK part of prog-indentation-context. So PREVIOUS-CHUNK only exists in the docstring of prog-indentation-context and nowhere else. >> Zero is not the intention: for the doc changes to be valid, we need to >> add a few `widen` calls in places like indent-according-to-mode. > If those calls are conditioned on MMM actually being active, then > existing behavior will remain unchanged, and we are good. How do you propose we detect when MMM is active? Stefan "and by the way, those widen calls are beneficial even when MMM is not active, but if you insist I'm OK delaying this side benefit to Emacs-27"