From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus Date: Sat, 03 Mar 2018 23:56:25 -0500 Message-ID: References: <20180304011814.8826.18896@vcs0.savannah.gnu.org> <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520139287 9380 195.159.176.226 (4 Mar 2018 04:54:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2018 04:54:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Glenn Morris To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 04 05:54:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esLfW-0001SI-CP for ged-emacs-devel@m.gmane.org; Sun, 04 Mar 2018 05:54:42 +0100 Original-Received: from localhost ([::1]:43570 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esLhX-000566-3T for ged-emacs-devel@m.gmane.org; Sat, 03 Mar 2018 23:56:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esLhI-00055v-Qo for emacs-devel@gnu.org; Sat, 03 Mar 2018 23:56:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esLhI-0004B6-6K for emacs-devel@gnu.org; Sat, 03 Mar 2018 23:56:32 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esLhE-00042s-Hx; Sat, 03 Mar 2018 23:56:28 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w244uQmf027728; Sat, 3 Mar 2018 23:56:26 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0F16966382; Sat, 3 Mar 2018 23:56:25 -0500 (EST) In-Reply-To: <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org> (Glenn Morris's message of "Sat, 3 Mar 2018 20:18:15 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6234=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6234> : inlines <6449> : streams <1780501> : uri <2602170> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223253 Archived-At: > (let ((passphrase > - (password-read-and-add > + (password-read > "Passphrase for secret key (RET for no passphrase): " cache-key))) > (if (string= passphrase "") > nil > + (and passphrase cache-key (password-cache-add cache-key passphrase)) > passphrase))) Shouldn't we wait 'til we have confirmation that the password is correct before calling password-cache-add? Stefan