* Re: [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus
[not found] ` <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org>
@ 2018-03-04 4:56 ` Stefan Monnier
2018-03-05 18:38 ` Glenn Morris
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2018-03-04 4:56 UTC (permalink / raw)
To: emacs-devel; +Cc: Glenn Morris
> (let ((passphrase
> - (password-read-and-add
> + (password-read
> "Passphrase for secret key (RET for no passphrase): " cache-key)))
> (if (string= passphrase "")
> nil
> + (and passphrase cache-key (password-cache-add cache-key passphrase))
> passphrase)))
Shouldn't we wait 'til we have confirmation that the password is correct
before calling password-cache-add?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus
2018-03-04 4:56 ` [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus Stefan Monnier
@ 2018-03-05 18:38 ` Glenn Morris
0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2018-03-05 18:38 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
> Shouldn't we wait 'til we have confirmation that the password is correct
> before calling password-cache-add?
Yes, you should totally do that. :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180304011814.8826.18896@vcs0.savannah.gnu.org>
[not found] ` <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org>
2018-03-04 4:56 ` [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus Stefan Monnier
2018-03-05 18:38 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).