Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Robert Pluim]

joaotavora@gmail.com (João Távora) writes:

> +your program and keep a change log.  In these situations, you may not
> +want to keep a separate versioned change log file.  If
> +@code{add-log-dont-create-changelog-file} is non-@code{nil}, commands
> +like @kbd{C-x 4 a} (@code{add-change-log-entry-other-window}) will
> +record changes in a suitably named temporary buffer instead of a file,
> +unless such a file already exists.

So if add-log-dont-create-changelog-file is t, but ChangeLog exists as
a file on disk, the entry goes there and not in the non-file ChangeLog
buffer? That would be surprising to me.

Robert

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Gmane-Reply-To-List: yes
> Date: Sun, 22 Jul 2018 12:16:48 +0200
> Cc: João Távora <joaotavora@gmail.com>
> 
> joaotavora@gmail.com (João Távora) writes:
> 
> > +your program and keep a change log.  In these situations, you may not
> > +want to keep a separate versioned change log file.  If
> > +@code{add-log-dont-create-changelog-file} is non-@code{nil}, commands
> > +like @kbd{C-x 4 a} (@code{add-change-log-entry-other-window}) will
> > +record changes in a suitably named temporary buffer instead of a file,
> > +unless such a file already exists.
> 
> So if add-log-dont-create-changelog-file is t, but ChangeLog exists as
> a file on disk, the entry goes there and not in the non-file ChangeLog
> buffer?

Yes.

> That would be surprising to me.

Why surprising?  First, this is the current behavior, so this way we
are less incompatible; and second, that's why the option has "create"
in its name.

Maybe I'm missing something.

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Robert Pluim]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Gmane-Reply-To-List: yes
>> Date: Sun, 22 Jul 2018 12:16:48 +0200
>> Cc: João Távora <joaotavora@gmail.com>
>> 
>> joaotavora@gmail.com (João Távora) writes:
>> 
>> > +your program and keep a change log.  In these situations, you may not
>> > +want to keep a separate versioned change log file.  If
>> > +@code{add-log-dont-create-changelog-file} is non-@code{nil}, commands
>> > +like @kbd{C-x 4 a} (@code{add-change-log-entry-other-window}) will
>> > +record changes in a suitably named temporary buffer instead of a file,
>> > +unless such a file already exists.
>> 
>> So if add-log-dont-create-changelog-file is t, but ChangeLog exists as
>> a file on disk, the entry goes there and not in the non-file ChangeLog
>> buffer?
>
> Yes.
>
>> That would be surprising to me.
>
> Why surprising?  First, this is the current behavior, so this way we
> are less incompatible; and second, that's why the option has "create"
> in its name.
>
> Maybe I'm missing something.

It has create, but it also has 'dont'. I guess I can see how it makes
sense if you already have a ChangeLog file lying around.

Anyway, I donʼt think I feel strongly enough about this to suggest a
change.

Robert

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

On Sun, Jul 22, 2018 at 3:18 PM, Robert Pluim <rpluim@gmail.com> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Robert Pluim <rpluim@gmail.com>
> >> Gmane-Reply-To-List: yes
> >> Date: Sun, 22 Jul 2018 12:16:48 +0200
> >> Cc: João Távora <joaotavora@gmail.com>
> >>
> >> joaotavora@gmail.com (João Távora) writes:
> >>
> >> > +your program and keep a change log.  In these situations, you may not
> >> > +want to keep a separate versioned change log file.  If
> >> > +@code{add-log-dont-create-changelog-file} is non-@code{nil},
> commands
> >> > +like @kbd{C-x 4 a} (@code{add-change-log-entry-other-window}) will
> >> > +record changes in a suitably named temporary buffer instead of a
> file,
> >> > +unless such a file already exists.
> >>
> >> So if add-log-dont-create-changelog-file is t, but ChangeLog exists as
> >> a file on disk, the entry goes there and not in the non-file ChangeLog
> >> buffer?
> >
> > Yes.
> >
> >> That would be surprising to me.
> >
> > Why surprising?  First, this is the current behavior, so this way we
> > are less incompatible; and second, that's why the option has "create"
> > in its name.
> >
> > Maybe I'm missing something.
>
> It has create, but it also has 'dont'. I guess I can see how it makes
> sense if you already have a ChangeLog file lying around.
>
> Anyway, I donʼt think I feel strongly enough about this to suggest a
> change.
>

It could be add-log-dont-create-new-changelog-file which maybe
would confuse even less people.

Feel free to change it, or don't, if it's not that big a deal.

João

[-- Attachment #2: Type: text/html, Size: 2699 bytes --]

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Stefan Monnier]

> It could be add-log-dont-create-new-changelog-file which maybe
> would confuse even less people.

Sounds good, tho I'd argue that the "-changelog" part is redundant.


        Stefan

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sun, 22 Jul 2018 15:02:38 -0400
> 
> > It could be add-log-dont-create-new-changelog-file which maybe
> > would confuse even less people.
> 
> Sounds good, tho I'd argue that the "-changelog" part is redundant.

OTOH, "dont-create-new-file" sounds too general to be self-explanatory
("what? it won't create _any_ file?")

Re: master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Stefan Monnier]

>> Sounds good, tho I'd argue that the "-changelog" part is redundant.
> OTOH, "dont-create-new-file" sounds too general to be self-explanatory
> ("what? it won't create _any_ file?")

AFAIK it is valid (add-log currently doesn't ever create any file except
for a ChangeLog file when none is found).


        Stefan

Re: [Emacs-diffs] master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Stefan Monnier]

>     New option to make 'C-x 4 a' use file-less ChangeLog buffers

Seems to work OK here, but `C-c C-a` in the *vc-log* buffer doesn't
seem to know how to get the message from those new buffers.
Do you have a corresponding patch for that in the works?


        Stefan

Re: [Emacs-diffs] master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Evidently I missed something, because I thought that part was included.

In my setup, it evens happens automatically when I vc-next-action and the
vc-log buffer appears.

I'm away from my computer now, doesn't it work for you like this in emacs
-Q?

João

On Wed, Jul 25, 2018, 20:10 Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> >     New option to make 'C-x 4 a' use file-less ChangeLog buffers
>
> Seems to work OK here, but `C-c C-a` in the *vc-log* buffer doesn't
> seem to know how to get the message from those new buffers.
> Do you have a corresponding patch for that in the works?
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1151 bytes --]

Re: [Emacs-diffs] master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Stefan Monnier]

> Evidently I missed something, because I thought that part was included.
> In my setup, it evens happens automatically when I vc-next-action and the
> vc-log buffer appears.
> I'm away from my computer now, doesn't it work for you like this in emacs
> -Q?

Hmm... maybe there was pilot error.  I'll take a second look and will
complain loudly if it still doesn't work.


        Stefan

Re: [Emacs-diffs] master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On Wed, Jul 25, 2018 at 8:49 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > Evidently I missed something, because I thought that part was included.
> > In my setup, it evens happens automatically when I vc-next-action and the
> > vc-log buffer appears.
> > I'm away from my computer now, doesn't it work for you like this in emacs
> > -Q?
>
> Hmm... maybe there was pilot error.  I'll take a second look and will
> complain loudly if it still doesn't work.
>

Yup, works for me from Emacs -Q. Maybe it's the way I'm
working:

Emacs -Q
M-x vc-dir RET some project RET
m to mark some changes files
M-x vc-diff
C-x 4 a (multiple times in diff buffer, copies to temp changelog buf)
switch back to vc dir buffer
M-x vc-next-action (this copies the entries I put down before)
C-c C-a copies the entries again and again

What exactly are you doing?

João

[-- Attachment #2: Type: text/html, Size: 1429 bytes --]

Re: [Emacs-diffs] master f96fe57: New option to make 'C-x 4 a' use file-less ChangeLog buffers

[Stefan Monnier]

> Yup, works for me from Emacs -Q.

Works for me too: pilot error.  Sorry 'bout the noise.


        Stefan