From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: hexl Date: Fri, 17 May 2019 12:23:13 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1408"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 18:23:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRfds-0000E6-23 for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 18:23:32 +0200 Original-Received: from localhost ([127.0.0.1]:50979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRfdq-0002X2-Q7 for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 12:23:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRfdl-0002Ww-5m for emacs-devel@gnu.org; Fri, 17 May 2019 12:23:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRfdj-0003dt-LO for emacs-devel@gnu.org; Fri, 17 May 2019 12:23:25 -0400 Original-Received: from [195.159.176.226] (port=51934 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRfdj-0003cc-AH for emacs-devel@gnu.org; Fri, 17 May 2019 12:23:23 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hRfdg-0018CK-14 for emacs-devel@gnu.org; Fri, 17 May 2019 18:23:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:3petEQ65gBR5NZKCVmKrXNJ+GHs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236678 Archived-At: > (let ((encoded (encode-coding-char ch coding)) > (internal (string-as-unibyte (char-to-string ch))) > internal-hex) > ;; If encode-coding-char returns nil, it means our character > ;; cannot be safely encoded with buffer-file-coding-system. > ;; In that case, we offer to insert the internal representation > ;; of that character, byte by byte. > > And here we really, really want the internal byte representation of the > multibyte string, so I think the code is correct and just needs a > with-no-warnings? I mean, > > (with-suppressed-warnings ((obsolete string-as-unibyte)) > (string-as-unibyte (char-to-string ch))) FWIW, this fallback behavior is a misfeature. We should rather signal an error. But I also consider hexl-mode as obsoleted by nhexl-mode, so my opinion is probably not terribly relevant, Stefan