From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: frameset Date: Sat, 18 May 2019 08:56:35 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173550"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 15:15:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRzB1-000iyz-0Q for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 15:15:03 +0200 Original-Received: from localhost ([127.0.0.1]:34127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRzAw-0002L0-Kd for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 09:14:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRzA0-0002Kh-5E for emacs-devel@gnu.org; Sat, 18 May 2019 09:14:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRz9z-0001a7-3q for emacs-devel@gnu.org; Sat, 18 May 2019 09:14:00 -0400 Original-Received: from [195.159.176.226] (port=56932 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRz9y-0001XY-RY for emacs-devel@gnu.org; Sat, 18 May 2019 09:13:59 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hRytH-000Kh2-CO for emacs-devel@gnu.org; Sat, 18 May 2019 14:56:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:KcIUYqo+XsMclnVTXXKzgxQDWqQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236717 Archived-At: > In frameset-to-register: > frameset.el:1403:18:Warning: ‘registerv-make’ is an obsolete function (as of > 27.1); Use your own type with methods on > register-val-(insert|describe|jump-to) > > It's this code: > > (set-register register > (registerv-make > (vector (frameset-save nil > :app 'register > :filters frameset-session-filter-alist) > ;; frameset-save does not include the value of point > ;; in the current buffer, so record that separately. > (frameset-frame-id nil) > (point-marker)) > :print-func #'frameset--print-register > :jump-func #'frameset--jump-to-register))) registerv-make faked OO-style programming by having objects that carry their methods. > I've never used register-val-*, so I have no idea what to do here... > anybody? The new style uses CLOS-style OO-programming instead. I.e. the object you put into the register should have its own distinctive type (i.e. not `registerv`) and you define the print/jump/.. methods with `cl-defmethod`. So, here you'd want to use a cl-defstruct to replace the `(vector ...)` object and then use dispatch on this defstruct's type when cl-defmethod'ing the register-val-print/jump/... functions. Does that make sense? Stefan