From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Date: Wed, 25 Mar 2020 23:42:39 -0400 Message-ID: References: <20200325204155.5002.75177@vcs0.savannah.gnu.org> <20200325204157.3643820E43@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="28578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 26 04:43:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHJQM-0007LB-6v for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Mar 2020 04:43:18 +0100 Original-Received: from localhost ([::1]:46000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHJQL-0005t5-71 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Mar 2020 23:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33140) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHJPs-0005SM-QH for emacs-devel@gnu.org; Wed, 25 Mar 2020 23:42:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHJPr-00065U-2q for emacs-devel@gnu.org; Wed, 25 Mar 2020 23:42:47 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46208) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHJPq-00065K-TF for emacs-devel@gnu.org; Wed, 25 Mar 2020 23:42:47 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0653944F898; Wed, 25 Mar 2020 23:42:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9DF0744F883; Wed, 25 Mar 2020 23:42:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585194160; bh=X7XQoSuFbCE0al6nAKUEKuL61SbGssvl8GKhoeJDlbc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hyttrcsX6FWKclSzyzTlAfDDlBtHMoV5VRc3gPYD/9XTeZNFNmqpLNv1sUpPVV/6Z rgiRQ+J9Iw6gJ0qOq0jlUipw0raXsGV/93AkKtk6qR0dZGp8cGuyxotwkSAkMh5AQ0 y6ar/XdTyFPeK52fjUVGqS6QWh2pRgtGQsQFdvBF5/P9GiLjzf6x8okXuitO9v9AvW l6JHzJkxMykFzbwUQ/KSE6kkjGa0jPCUQyrfK+AD97BC3VpkmjQKyNAUtWwAXO9ELz 4LCQQC3NQ7jUQ+KZq65DRFQWd15+Tx22MQhMr6b+eLb37Jbm9Y9D5wI8jQI/DHioY9 xGxY+r+hpTPig== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 668D91204BA; Wed, 25 Mar 2020 23:42:40 -0400 (EDT) In-Reply-To: ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Wed, 25 Mar 2020 23:29:50 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245799 Archived-At: >> The regular expressions are written either with or without case-folding >> in mind, so changing it globally is a recipe for problems. > Agreed, but I doubt that anyone will ever set the option. Then let's make it into a simple `defvar` rather than a defcustom and make the docstring clarify that it's only useful for temporary backward compatibility. >> PS: The same applies to the "zero/one-based column numbers" and >> the "char-colums vs visual-columns vs byte-columns", admittedly. > > Yes, those settings would make more sense if they were rule-specific. > Still, actual examples of tools needing them would be useful. In sml-mode.el (GNU ELPA) I set `compilation-error-screen-columns` buffer-locally but it really should be rule-local. In tuareg-mode (not in GNU ELPA, sadly), I set both `compilation-first-column` and `compilation-error-screen-columns` buffer-locally for the same reason. Stefan