From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New packages: boxy, boxy-headlines Date: Mon, 04 Oct 2021 21:47:26 -0400 Message-ID: References: <87zgro8sdr.fsf@gmail.com> <87v92c7571.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tyler Grinn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 05 03:48:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXZZ2-0001Nk-1Q for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 03:48:16 +0200 Original-Received: from localhost ([::1]:40996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXZZ0-00036b-7v for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 21:48:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXZYN-0002PM-IJ for emacs-devel@gnu.org; Mon, 04 Oct 2021 21:47:36 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXZYJ-0003NA-Jw for emacs-devel@gnu.org; Mon, 04 Oct 2021 21:47:33 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E70AD1003ED; Mon, 4 Oct 2021 21:47:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A084100305; Mon, 4 Oct 2021 21:47:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633398447; bh=Z7PmxKV79dUlI/CLWpztlo9Hn4nAu6IaAeqxl11Su6g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IhxVuRKNTaeFvh4ywlDPW3rEjFVxMPjx2Tvpz1RAaxd2whr8TUKkjca8FW2Y6xSvb E2BDFwAQYQuWP5D3YB0sCu7KubIUe+eV6gcWSxu3HrTkceFWuZ76zAzOcZ4qM8TMlx i2Ml8ex4GDOL/76fbSzEayMtteyn0uw4g9OrEwxBwELN5GEtK0flvCA5yagwcHv+Xt MbgklK4TKSLQunZ0ohZf68wZJNnTXDpSCX9Ef49r0ETJRKTPYcygNE4R4H7JSz//ji +GjNJ+hP2Pa5G4xhBrtzJgiLl5ttugynvihpQk6weOa9ZWFXmxPsgo96kLLvFjUUaR 2QFd/kdY5WHSg== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F362012022E; Mon, 4 Oct 2021 21:47:26 -0400 (EDT) In-Reply-To: <87v92c7571.fsf@gmail.com> (Tyler Grinn's message of "Mon, 04 Oct 2021 19:14:58 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276288 Archived-At: > Defface wasn't working for me when updating the color scheme. Repeated > calls to defface don't seem to apply changes, while directly modifying > the face-defface-spec does. AFAIK, same as for `defvar`, this is on-purpose. If you want to re-apply the standard definition, the recommended way is to use `C-M-x`. >> - Your packages have no ;;;###autoload cookie. The doc of boxy.el >> doesn't make it clear what's a likely entry point (i.e. how to start >> using it), but for `boxy-headings`, it seems at least the >> `boxy-headlines` function should have such a cookie. > > I think you're right about the boxy-headlines command. boxy.el provides > the boxy major mode and related commands, should those be autoloaded? IIUC `boxy.el` (including the major mode) is not meant to be used directly by the end user, so maybe it doesn't need any autoloads because the clients will just (require 'boxy) at the top of their file. I don't know enough about how `boxy.el` is used by client packages: you're in a better position to know. >> Oh, I forgot the main question (the one that got me looking more >> closely in the first place): why do you use `cl-defmethod` everywhere >> yet with only ever a single method defined under the same name? > That was so (oref) and (oset) can work without ELC complaining about > 'unknown slots'. Is there another macro that uses class specializers? Hmm... I don't understand why using `cl-defmethod` would silence "unknown slot" warnings. AFAIK those warnings depend solely on whether the byte-compiler has seen the corresponding `defclass`. > Also, why not assign custom variables and faces to a group? Removing those `:group` will not stop them from being assigned to those groups (IOW those `:group` args are simply redundant because vars and faces are assigned (by default) to the last group defined with `defgroup`). Stefan