From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sat, 12 Feb 2022 14:42:07 -0500 Message-ID: References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3532"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 12 20:44:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIyJz-0000k0-MJ for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 20:44:39 +0100 Original-Received: from localhost ([::1]:37550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIyJy-0005uu-C4 for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 14:44:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIyHd-0004Lw-A3 for emacs-devel@gnu.org; Sat, 12 Feb 2022 14:42:13 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIyHb-0005mP-5H; Sat, 12 Feb 2022 14:42:12 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D187A80401; Sat, 12 Feb 2022 14:42:09 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 87BBB8041E; Sat, 12 Feb 2022 14:42:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644694928; bh=nzjKQx4nobw7btshHSQs8cDlUciQ4dv0eITkGtpTIRU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ngD0R45LbmY8zSydSOw7fxh7lwDXyN5Xo1Co47hY3gIyE8ZL9rpbY45tz22iwjIPH zrK4HxQZm6t9HD1wUyFwahv4jHEC5W27cCk1CBsddlw4+8wios/fNB8eFZ6ljyO7Uh OAs0iPkzuU1gS8r3P58RXb1j4tQpTY0ScVhP0MPHlrXPF3nWpgm4OXNTCU1QF3CJfP pn4P21NNqVc8KVbXhJnVsy3soiS64olOYpitWgdVbEC6FdWfzzaCnb6AUEVWeWOy5G w8QVx6LGvKIXdAwyyFDErO6cnDNCO66H9KRd86zo9MjAuTktFeU9yVmeNDYK2xu+pr vB5IgEJzpqKUQ== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5D6EE120BCE; Sat, 12 Feb 2022 14:42:08 -0500 (EST) In-Reply-To: <83tud3ri2n.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Feb 2022 21:38:40 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286194 Archived-At: >> I know. And I'm asking why `file-size-human-readable` gives so >> much accuracy. > > It's a feature: > > (format (if (and (>= (mod file-size 1.0) 0.05) > (< (mod file-size 1.0) 0.95)) > "%.1f%s%s" > "%.0f%s%s") Why is it a feature to waste those two perfect good characters on such irrelevant details? Stefan